gb-studio: init at 3.1.0 #268959
Closed
gb-studio: init at 3.1.0 #268959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
|
I don't know how to install desktop file and icons. To do so, I need to override some phase but every phase is needed and is hard to recreate (I wish I could use something like My progress: { lib
, mkYarnPackage
, fetchFromGitHub
, makeDesktopItem
, imagemagick
, nodejs
, yarn
}:
mkYarnPackage rec {
pname = "gb-studio";
version = "3.2.1";
src = fetchFromGitHub {
owner = "chrismaltby";
repo = "gb-studio";
rev = "refs/tags/v${version}";
hash = "sha256-hF8aDTg7v9p0d9AUE2NNhQACgggMEbi5afzK1GqUHx0=";
};
strictDeps = true;
# doDist = false;
nativeBuildInputs = [
imagemagick
nodejs
yarn
];
# installPhase = let
# desktopItem = makeDesktopItem {
# name = pname;
# desktopName = "GB Studio";
# comment = "Visual retro game maker";
# genericName = "GB Studio";
# exec = "${meta.mainProgram} %U";
# icon = pname;
# type = "Application";
# startupNotify = true;
# categories = [ "Development" "Building" "IDE" ];
# };
# in ''
# runHook preInstall
#
# pushd ./deps/gb-studio
# for size in 64 128 256 512 1024; do
# mkdir -p $out/share/icons/hicolor/"$size"x"$size"/
# convert -resize "$size"x"$size" ./src/assets/app/icon/app_icon.png \
# $out/share/icons/hicolor/"$size"x"$size"/${pname}.png
# done
# popd
#
# install -Dm 644 ${desktopItem}/share/applications/*.desktop \
# -t $out/share/applications
#
# runHook postInstall
# '';
meta = {
description = "A quick and easy to use drag and drop retro game creator for your favourite handheld video game system";
homepage = "https://www.gbstudio.dev/";
downloadPage = "https://chrismaltby.itch.io/gb-studio";
changelog = "https://github.com/chrismaltby/gb-studio/releases/tag/v${version}";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ ashgoldofficial musjj ];
mainProgram = pname;
platforms = lib.platforms.linux;
};
} |
|
Try the copyDesktopItems hook |
eclairevoyant
suggested changes
Jun 29, 2024
| }; | ||
| # bash | ||
| in '' | ||
| mv "$out/bin/${pname}-${version}" "$out/bin/${pname}" |
There was a problem hiding this comment.
Suggested change
| mv "$out/bin/${pname}-${version}" "$out/bin/${pname}" |
|
|
||
| src = fetchurl { | ||
| url = | ||
| "https://github.com/chrismaltby/${pname}/releases/download/v${version}/${pname}-linux.AppImage"; |
There was a problem hiding this comment.
Suggested change
| "https://github.com/chrismaltby/${pname}/releases/download/v${version}/${pname}-linux.AppImage"; | |
| "https://github.com/chrismaltby/gb-studio/releases/download/v${version}/gb-studio-linux.AppImage"; |
| "A quick and easy to use drag and drop retro game creator for your favourite handheld video game system"; | ||
| homepage = "https://www.gbstudio.dev/"; | ||
| changelog = | ||
| "https://github.com/chrismaltby/${pname}/releases/tag/v${version}"; |
There was a problem hiding this comment.
Suggested change
| "https://github.com/chrismaltby/${pname}/releases/tag/v${version}"; | |
| "https://github.com/chrismaltby/gb-studio/releases/tag/v${version}"; |
|
|
||
| meta = with lib; { | ||
| description = | ||
| "A quick and easy to use drag and drop retro game creator for your favourite handheld video game system"; |
There was a problem hiding this comment.
Suggested change
| "A quick and easy to use drag and drop retro game creator for your favourite handheld video game system"; | |
| "Quick and easy to use drag and drop retro game creator for your favourite handheld video game system"; |
| cp ${desktopItem}/share/applications/*.desktop $out/share/applications | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
tracking issue: #292468
Comment on lines
+43
to
+46
| license = licenses.mit; | ||
| platforms = [ "x86_64-linux" ]; | ||
| sourceProvenance = with sourceTypes; [ binaryBytecode ]; | ||
| maintainers = with maintainers; [ musjj ]; |
There was a problem hiding this comment.
Suggested change
| license = licenses.mit; | |
| platforms = [ "x86_64-linux" ]; | |
| sourceProvenance = with sourceTypes; [ binaryBytecode ]; | |
| maintainers = with maintainers; [ musjj ]; | |
| license = lib.licenses.mit; | |
| platforms = [ "x86_64-linux" ]; | |
| sourceProvenance = with lib.sourceTypes; [ binaryBytecode ]; | |
| maintainers = with lib.maintainers; [ musjj ]; |
| @@ -3846,6 +3846,8 @@ with pkgs; | |||
|
|
|||
| gams = callPackage ../tools/misc/gams (config.gams or {}); | |||
|
|
|||
| gb-studio = callPackage ../development/tools/gb-studio { }; | |||
There was a problem hiding this comment.
please move this to pkgs/by-name and remove this line
wegank
added
the
2.status: stale
|
Closing because of unresponsive author |
|
since when did we start closing stale PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
GB Studio: A quick and easy to use drag and drop retro game creator for your favourite handheld video game system.
Just a simple wrapper around the pre-built AppImage executable for now. I really wanted to build the package from source, but I gave up after spending two whole days fighting with Yarn, Electron and RPATH.
closes: #185564
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.