Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.fidget-nvim: switch branch from legacy to main #269831

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 25, 2023

Description of changes

The fidget.nvim plugin has been going through a substantial rewrite lately. Hence, the nixpkgs was set to target the legacy branch as recommended by the devs.
Now, the rewrite has been completed so we should go back and use the default branch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 269831 run on x86_64-linux 1

1 package built:
  • vimPlugins.fidget-nvim

@teto
Copy link
Member

teto commented Nov 25, 2023

impossible not to merge after this great motivation message ;)
I've done the migration myself and it was pretty smooth, it just complained about an outdated setting and kept working.

@teto teto merged commit 5304b1a into NixOS:master Nov 25, 2023
28 of 29 checks passed
@GaetanLepage GaetanLepage deleted the fidget-nvim branch November 25, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants