Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline63: fix clang build #270814

Merged
merged 1 commit into from
Nov 29, 2023
Merged

readline63: fix clang build #270814

merged 1 commit into from
Nov 29, 2023

Conversation

emilytrau
Copy link
Member

Description of changes

ZHF #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

ghost
ghost approved these changes Nov 29, 2023
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 270814 run on x86_64-darwin 1

5 packages built:
  • readline63
  • readline63.dev
  • readline63.doc
  • readline63.info
  • readline63.man

no derivation change for x64 linux so no builds needed:
Result of nixpkgs-review pr 270814 run on x86_64-linux 1

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 29, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 29, 2023
@emilytrau emilytrau merged commit eb9abdb into NixOS:master Nov 29, 2023
26 of 27 checks passed
@emilytrau emilytrau deleted the readline63-clang branch November 29, 2023 07:37
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilytrau @delroth