Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcsc-tools: 1.6.2 -> 1.7.0 #272745

Merged
merged 8 commits into from
Dec 18, 2023
Merged

pcsc-tools: 1.6.2 -> 1.7.0 #272745

merged 8 commits into from
Dec 18, 2023

Conversation

anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Dec 7, 2023 •
edited
Loading

Description of changes

https://github.com/LudovicRousseau/pcsc-tools/releases/tag/1.7.0
LudovicRousseau/pcsc-tools@1.6.2...1.7.0

  • Added passthru.updateScript
  • Added passthru.tests.version
  • Added meta.{changelog,mainProgram}
  • Added myself to maintainers
  • Renamed package attribute name to pcsc-tools be consistent with pname and upstream name
  • Fixed darwin build

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@anthonyroussel anthonyroussel changed the title pcsctools: 1.6.2 -> 1.7.0 pcsc-tools: 1.6.2 -> 1.7.0 Dec 7, 2023
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Dec 7, 2023
@ofborg ofborg bot requested a review from peterhoeg December 7, 2023 21:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 7, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 9, 2023
@marsam marsam merged commit 2147020 into NixOS:master Dec 18, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyroussel @marsam