Introduce 10.13 libdispatch #273013
Open
Introduce 10.13 libdispatch #273013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
13 tasks
wegank
added
the
2.status: merge conflict
The `applePackageMapping` function will allow us to keep expressions for the newer releases separate from the originals where necessary, without needing to change `generate-sdk-packages.sh`. If we ever want to support multiple versions of source releases simultaneously we should consider changing that to point to versioned subdirectories of all the packages. Many of the source releases introduced here will need changes to the expression to build successfully. These will be introduced one by one.
Releases with dependencies on other releases, e.g., libresolv depends on Libinfo, mDNSResponder and configdHeaders, were getting those releases from pkgs.darwin rather than pkgs.darwin."10.13.6". By making the scope of callPackage overridable we can manipulate which packages are used to supply dependencies.
These are not part of the SDK so we shouldn't need them in general.
TODO: Evaluate whether CF still needs these and add a privateHeaders
output.
toonn
force-pushed
the
introduce-10.13-libdispatch
branch
from
f343146
to
a755a3d
Compare
ofborg
bot
removed
the
2.status: merge conflict
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
These are not part of the SDK so we shouldn't need them in general.
TODO: Evaluate whether CF still needs these and add a privateHeaders output.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.