-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgs/by-name
: Enable gradual migration checks and add run-local.sh
#274591
Commits on Dec 19, 2023
-
workflows/check-by-name: Move tool fetching into script
This part of the CI can also be reproduced locally
Configuration menu - View commit details
-
Copy full SHA for 3869ba4 - Browse repository at this point
Copy the full SHA 3869ba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c626788 - Browse repository at this point
Copy the full SHA c626788View commit details
Commits on Dec 20, 2023
-
tests.nixpkgs-check-by-name: Create script to run locally
Due to the check soon depending on the base branch (see `--base`), the CI check can't reasonably share all code with a local check. We can still make a script to run it locally, just not sharing all code.
Configuration menu - View commit details
-
Copy full SHA for 92238ac - Browse repository at this point
Copy the full SHA 92238acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e03178 - Browse repository at this point
Copy the full SHA 9e03178View commit details -
workflows/check-by-name: Slim down and prepare for --base
Now that we have a script to run the check locally, there's no real need to output the information to reproduce anymore, which allows cleaning up the CI workflow. Furthermore, this prepares the CI workflow to be passed `--base`, as introduced recently.
Configuration menu - View commit details
-
Copy full SHA for 1ad45e5 - Browse repository at this point
Copy the full SHA 1ad45e5View commit details -
check-by-name: Pass --base in CI and local running script
This enables the ratchet checks for pkgs/by-name, allowing gradual migrations!
Configuration menu - View commit details
-
Copy full SHA for 1968bee - Browse repository at this point
Copy the full SHA 1968beeView commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f882df7 - Browse repository at this point
Copy the full SHA f882df7View commit details -
pkgs/test/nixpkgs-check-by-name/scripts: Various improvements
- trace function, avoids littering `echo >&2` all throughout - Avoid `eval`, remove unneeded shellcheck Co-Authored-By: Victor Engmark <victor@engmark.name>
Configuration menu - View commit details
-
Copy full SHA for e130ee3 - Browse repository at this point
Copy the full SHA e130ee3View commit details