Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatpak-pip-generator: init at unstable-2023-11-27 #274751

Closed
wants to merge 1 commit into from

Conversation

auroraanna
Copy link
Contributor

@auroraanna auroraanna commented Dec 16, 2023

Description of changes

  • added flatpak-pip-generator package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@auroraanna auroraanna force-pushed the flatpak-pip-generator branch 2 times, most recently from 586f243 to 1a7f53b Compare January 2, 2024 13:27
Co-authored-by: Donovan Glover <donovan@dglover.co>
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 2, 2024

meta = with lib; {
description = "Automatically generates flatpak-builder manifest from a pip package name";
licenses = with licenses; [ mit ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
licenses = with licenses; [ mit ];
license = with licenses; [ mit ];

@Aleksanaa
Copy link
Member

Sorry for closing, CI not passing and without proper fix for a long time. If you want to work on this again, you can reopen it.

@Aleksanaa Aleksanaa closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants