addOpenGLRunpath: deprecate #275241
Merged
addOpenGLRunpath: deprecate #275241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: nixos
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
39d0fb6 to
498f546
Compare
10 tasks
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
12796d9 to
651a917
Compare
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
651a917 to
d866f75
Compare
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
3 times, most recently
from
5004111 to
d972a62
Compare
github-actions
bot
added
the
8.has: documentation
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
d972a62 to
52af22e
Compare
|
Looks like |
wegank
added
the
2.status: merge conflict
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
52af22e to
c09be86
Compare
github-actions
bot
removed
the
8.has: documentation
|
As #301176 already dealt with the CUDA part, I rebased and reduced the scope of this PR to |
Scrumplex
changed the title
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
and removed
2.status: merge conflict
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
c09be86 to
bd25f10
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4089 |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
treewide/use-addDriverRunpath
branch
from
bd25f10 to
416ba88
Compare
| @@ -69,6 +69,8 @@ mapAliases ({ | |||
| adtool = throw "'adtool' has been removed, as it was broken and unmaintained"; | |||
| adom = throw "'adom' has been removed, as it was broken and unmaintained"; # added 2024-05-09 | |||
| advcpmv = throw "'advcpmv' has been removed, as it is not being actively maintained and break recent coreutils."; # Added 2024-03-29 | |||
| # Post 24.11 branch-off, this should throw an error | |||
| addOpenGLRunpath = addDriverRunpath; # Added 2024-05-25 | |||
There was a problem hiding this comment.
I think it's OK to make this a lib.warn even
There was a problem hiding this comment.
I tried that in the first iteration of this PR, but ofborg will complain as it'll try to evaluate addOpenGLRunpath
There was a problem hiding this comment.
If we could ensure it doesn't complain later in other people's PRs... regardless, let's just merge this as is
There was a problem hiding this comment.
Actually. I'm pretty sure warns in aliases.nix are allowed. Ofborg should only complain if there's a derivation left that actually asks for addOpenGLRunpath instead of addDriverRunpath
SomeoneSerge
approved these changes
Jun 30, 2024
|
Thank you @Scrumplex |
13 tasks
Nanotwerp
added a commit
to Nanotwerp/browser-previews
that referenced
this pull request
Nov 26, 2024
`addOpenGLRunpath` was deprecated in this PR NixOS/nixpkgs#275241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Now that #269475 is merged, let's go ahead and
addOpenGLRunpathaddDriverRunPathIt looks like the last PR didn't introduce anSee #301176autoAddDriverRunpathHookhelper for cuda packages. If desired, I can move it into a separate PR.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.