gargoyle: 2019.1.1 -> 2023.1

[vq]

• latest released version

• uses cmake instad of jam

Description of changes

https://github.com/garglk/garglk/releases

Added workaround for double-slash in path error in cmake .pc file. It may or may not have something to do with this nixpkgs issue: #144170

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pbsbot]

Result of nixpkgs-review pr 276280 run on x86_64-linux 1

1 package failed to build:

• gargoyle

In file included from /build/source/garglk/main.cpp:25:
/build/source/garglk/garglk.h:383:22: error: 'uint8_t' is not a member of 'std'; did you mean 'wint_t'?
  383 |     std::vector<std::uint8_t> &at(int number);
      |                      ^~~~~~~
      |                      wint_t
/build/source/garglk/garglk.h:383:29: error: template argument 1 is invalid
  383 |     std::vector<std::uint8_t> &at(int number);
      |                             ^
/build/source/garglk/garglk.h:383:29: error: template argument 2 is invalid
/build/source/garglk/garglk.h:386:63: error: 'uint8_t' is not a member of 'std'; did you mean 'wint_t'?
  386 |     std::unordered_map<int, nonstd::optional<std::vector<std::uint8_t>>> m_bleeps = {
      |                                                               ^~~~~~~
      |                                                               wint_t
/build/source/garglk/garglk.h:386:63: error: template argument 1 is invalid
/build/source/garglk/garglk.h:386:63: error: template argument 2 is invalid
/build/source/garglk/garglk.h:386:70: error: template argument 1 is invalid
  386 |     std::unordered_map<int, nonstd::optional<std::vector<std::uint8_t>>> m_bleeps = {
      |                                                                      ^~
/build/source/garglk/garglk.h:386:72: error: template argument 2 is invalid
  386 |     std::unordered_map<int, nonstd::optional<std::vector<std::uint8_t>>> m_bleeps = {
      |                                                                        ^
/build/source/garglk/garglk.h:386:72: error: template argument 5 is invalid
/build/source/garglk/garglk.h:389:5: error: cannot convert '<brace-enclosed initializer list>' to 'int' in initialization
  389 |     };
      |     ^

[smancill]

Superseded by #291614?

[vq]

Yup, thanks for the notice smancill.