Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/paperless: convert extraConfig to freeform type #277019

Merged
merged 1 commit into from
Jan 4, 2024
Merged

nixos/paperless: convert extraConfig to freeform type #277019

merged 1 commit into from
Jan 4, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2023 •
edited
Loading

Description of changes

Tested on installation including with the types in the example.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 27, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 27, 2023
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review December 28, 2023 00:38
@SuperSandro2000 SuperSandro2000 requested review from 999eagle, Atemu and AndersonTorres and removed request for 999eagle December 28, 2023 00:41
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 28, 2023
Atemu
Atemu reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed, thanks.

A couple notes and improvements.

Tested to be working :)

nixos/modules/services/misc/paperless.nix Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 changed the title nixos/paperless: convert extraConfig to freeform nixos/paperless: convert extraConfig to freeform type Dec 29, 2023
@SuperSandro2000 SuperSandro2000 force-pushed the paperless-freeform branch 3 times, most recently from 9e87946 to 5d9f8a9 Compare December 29, 2023 21:42
@mweinelt
Copy link
Member

Please make sure to loop in the maintainers, when you're only changing the module, as they don't get requested by ofBorg in that case.

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 31, 2023
@SuperSandro2000 @Atemu
nixos/paperless: convert extraConfig to freeform type
7c1b4b2 
Co-authored-by: Atemu <atemu.main@gmail.com>
leona-ya
leona-ya approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 4, 2024
@Atemu Atemu merged commit 94e446c into NixOS:master Jan 4, 2024
20 checks passed
@SuperSandro2000 SuperSandro2000 deleted the paperless-freeform branch January 6, 2024 16:21
yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request Jan 9, 2024
@yayayayaka
nixosTests.paperless: Convert paperless extraConfig to settings
4500a82 
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in NixOS#277019.
@yayayayaka yayayayaka mentioned this pull request Jan 9, 2024
Merged
13 tasks
yayayayaka added a commit that referenced this pull request Jan 9, 2024
@yayayayaka
nixosTests.paperless: Convert paperless extraConfig to settings
0b3fbec 
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in #277019.
@patka-123 patka-123 mentioned this pull request Jan 30, 2024
Merged
13 tasks
peterablehmann added a commit to peterablehmann/nix-servers that referenced this pull request May 26, 2024
@peterablehmann
extraConfig Option has been renamed in NixOS/nixpkgs#277019
ab50bb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

@leona-ya leona-ya leona-ya approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@lukegb lukegb Awaiting requested review from lukegb

@gador gador Awaiting requested review from gador

@erikarvstedt erikarvstedt Awaiting requested review from erikarvstedt

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SuperSandro2000 @mweinelt @AndersonTorres @dotlambda @leona-ya @Atemu @delroth