Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klocalizer: init at 4.5.1 #278970

Closed
wants to merge 3 commits into from
Closed

klocalizer: init at 4.5.1 #278970

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2024

Description of changes

New package. This contains glue logic to be able to issue z3 (SAT/SMT solver) queries against the Linux Kconfig option database.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

pkgs/by-name/kl/klocalizer/package.nix Outdated Show resolved Hide resolved
requests
];

meta = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why not the typical ASCIIbetical ordering?
  2. Add changelog at https://github.com/paulgazz/kmax/releases/tag/v${version}

pkgs/by-name/kl/klocalizer/package.nix Outdated Show resolved Hide resolved
}:

let
version = "4.5.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal nit: I like to let-block pname, version and src.
It is useful because changelog usually points to src.rev.

Adam Joseph and others added 2 commits January 6, 2024 18:52
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@ghost ghost closed this Jan 23, 2024
@ghost ghost deleted the pr/klocalizer/init branch January 23, 2024 06:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant