Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./maintainers/scripts/check-by-name.sh: delete broken -I argument #282226

Closed
wants to merge 1 commit into from
Closed

./maintainers/scripts/check-by-name.sh: delete broken -I argument #282226

wants to merge 1 commit into from

Commits on Jan 20, 2024

  1. ./maintainers/scripts/check-by-name.sh: fix broken -I argument 

    Running CI locally is broken becauses the `-I` argument:

- Clobbers $NIX_PATH
- Is wrong for two reasons:
  - Has too many `..` elements, relative to the script's location
  - Isn't relative to the script's location (as with *.nix files),
    since shell scripts and POSIX in general interpret paths
    relative to the current working directory, not the canonical
    path of argv[0]
- Is inconsistent, since this script has symlinks pointing at it
  from different depths in the repository

There is no way to set this flag statically in a way that will work
everywhere.  The caller needs to use $NIX_PATH, or the script needs
to take the `-I` value as an argument.

This commit deletes the static `-I` flag.
    Adam Joseph committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    12e95aa View commit details
    Browse the repository at this point in the history