Reopen #263082 "make-derivation.nix: lib.warn if drv.__spliced missing" #283295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid setting off the unspliced-dependency check, we need to make sure that the targetPackages.stdenv.cc.bintools used by gcc gets spliced. In order for it to be spliced, it needs a top-level entry in all-packages.nix. Therefore, this commit adds one. This also causes us to stop abusing targetPackages to access the linker, which is a good thing.
This commit adds a `lib.warn` check to stdenv.mkDerivation, causing it to emit a warning if a dependency which ought to be spliced in fact is not.
Co-authored-by: Artturi <Artturin@artturin.com>
…s in buildInputs" This reverts commit 0899b6b8746790eec9dc49ea4f4a6c3def072e3b.
kjeremy
force-pushed
the
res/stdenv/warn-missing-splices
branch
from
ec58a9e
to
f3b4dee
Compare
kjeremy
force-pushed
the
res/stdenv/warn-missing-splices
branch
from
4e9b61c
to
3559fb2
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
Mic92
reviewed
Jan 24, 2024
| # `pkgsBuildHost`. | ||
| # | ||
| # Please take a moment to try to fix your PR. If you | ||
| # can't get it fixed, ping @amjoseph-nixpkgs who can |
There was a problem hiding this comment.
This should be probably changed than:
Suggested change
| # can't get it fixed, ping @amjoseph-nixpkgs who can | |
| # can't get it fixed, ping @amjoseph-nixpkgs who can |
There was a problem hiding this comment.
@Mic92 it looks like the suggested change is what's currently there. The buttons to accept the change are greyed out.
wegank
added
the
2.status: merge conflict
rrbutani
added
the
6.topic: cross-compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Reopen @amjoseph-nixpkgs's #263082
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.