grafana: fix build failure on darwin

[shivaraj-bh]

Description of changes

resolves #273998

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[shivaraj-bh]

Good news! the package successfully builds on aarch64-darwin.

Unfortunately, it fails on x86_64-darwin with no member named 'aligned_alloc' in the global namespace.. I fixed this by borrowing the fix from here.

Later it fails to build https://github.com/mattn/go-ieproxy, which seems to be related to #243298 (comment)

Error while trying to build go-ieproxy:

# github.com/mattn/go-ieproxy
In file included from ../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.3/ieproxy_darwin.go:7:
In file included from /nix/store/fgvsc1in07pjmp057dar58k2wms3nk6b-apple-framework-CFNetwork-11.0.0/Library/Frameworks/CFNetwork.framework/Headers/CFProxySup>
In file included from /nix/store/fgvsc1in07pjmp057dar58k2wms3nk6b-apple-framework-CFNetwork-11.0.0/Library/Frameworks/CFNetwork.framework/Headers/CFNetworkD>
In file included from /nix/store/ybqjzlwc8iazf693ffkvifj23zlsqf8p-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/>
In file included from /nix/store/ybqjzlwc8iazf693ffkvifj23zlsqf8p-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/>
In file included from /nix/store/ybqjzlwc8iazf693ffkvifj23zlsqf8p-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/>
/nix/store/ybqjzlwc8iazf693ffkvifj23zlsqf8p-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:1189:83: error>
    kCFURLBookmarkCreationWithSecurityScope API_AVAILABLE(macos(10.7), macCatalyst(13.0))  API_UNAVAILABLE(ios, watchos, tvos) = ( 1UL << 11 ), // Mac OS X >
                                                                                  ^
/nix/store/ybqjzlwc8iazf693ffkvifj23zlsqf8p-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:1190:98: error>
    kCFURLBookmarkCreationSecurityScopeAllowOnlyReadAccess API_AVAILABLE(macos(10.7), macCatalyst(13.0)) API_UNAVAILABLE(ios, watchos, tvos) = ( 1UL << 12 )>
                                                                                                 ^
/nix/store/ybqjzlwc8iazf693ffkvifj23zlsqf8p-apple-framework-CoreFoundation-11.0.0/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:1200:85: error>
    kCFURLBookmarkResolutionWithSecurityScope API_AVAILABLE(macos(10.7), macCatalyst(13.0)) API_UNAVAILABLE(ios, watchos, tvos) = ( 1UL << 10 ), // Mac OS X>
                                                                                    ^
3 errors generated.

[Ma27]

The if/else here is wrong because we don't just have Linux or Darwin (see lib.platforms) even though they're less well-known.

We should either do an if/else if for stdenv.isLinux/stdenv.isDarwin and throw on else if we're sure that for each Darwin and Linux the hash is the same (please check that then).
The other option would be to specify hashes explicitly per platform:

hash = {
  x86_64-linux = "hash1";
  aarch64-darwin = "hash2";
  aarch64-linux = "hash3";
}.${system} or throw "Unsupported system";

This has the downside that we'll duplicate hashes for Linuxes though.

In any case, please make sure that we don't allow any platform in meta.platforms that's excluded / unsupported here.

[shivaraj-bh]

6df2921

[shivaraj-bh]

Turns out, using xcbuild.xcbuild instead of just xcbuild avoids the headers getting mixed up between different versions of apple_sdk, solving the problem with go-ieproxy above. I am not entirely sure what makes it work, as far as I see the only difference between the outputs of both is that most of the binaries in xcbuild are just symlinks to the outputs in xcbuild.xcbuild.

[risicle]

nixpkgs-review happy, macos 12 x86_64 & nixos x86_64

[risicle]

Could you squash the commits? Or at least, if you think they really deserve to be separate commits, prefix each of the messages with grafana: ?

[shivaraj-bh]

@risicle I have squashed the commits

[Ma27]

I think meta.platforms should be restricted to x86_64-{darwin,linux}, aarch64-{darwin,linux}.

After that this is good to go, thanks!