Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_{12,13,14,15,16,17,18,git}: use common compiler-rt #303479

Merged
merged 1 commit into from
Apr 13, 2024
Merged

llvmPackages_{12,13,14,15,16,17,18,git}: use common compiler-rt #303479

merged 1 commit into from
Apr 13, 2024

Conversation

RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Apr 11, 2024 •
edited
Loading

Description of changes

Partial split from #299807

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100 labels Apr 11, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-compiler-rt branch 2 times, most recently from bd9673a to 94f91f1 Compare April 12, 2024 06:49
@RossComputerGuy RossComputerGuy changed the title lvmPackages_{12,13,14,15,16,17,18,git}: use common compiler-rt llvmPackages_{12,13,14,15,16,17,18,git}: use common compiler-rt Apr 12, 2024
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-compiler-rt branch from 94f91f1 to 9a5b7e7 Compare April 12, 2024 06:58
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-compiler-rt branch from 9a5b7e7 to a217161 Compare April 12, 2024 20:33
@RossComputerGuy RossComputerGuy force-pushed the feat/llvm-git-commonify-compiler-rt branch from a217161 to 3122646 Compare April 12, 2024 20:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Apr 12, 2024
@wegank wegank merged commit 8a26b55 into NixOS:master Apr 13, 2024
21 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/llvm-git-commonify-compiler-rt branch April 13, 2024 14:31
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
@rrbutani rrbutani mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovek323 lovek323 Awaiting requested review from lovek323

@alyssais alyssais Awaiting requested review from alyssais

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@dtzWill dtzWill Awaiting requested review from dtzWill

@rrbutani rrbutani Awaiting requested review from rrbutani

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RossComputerGuy @rrbutani @wegank