promscale_extension,buildPgxExtension: remove #305572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please also remove |
…package
postgresql14Packages.promscale_extension breaks with:
Error:
0: `pgx-0.6.1` shouldn't be used with `cargo-pgx-0.7.4`,
please use `pgx = "~0.7.4"` in your `Cargo.toml`.
However, pinning cargo-pgx to 0_6_1 via the following
buildPgxExtension.override { cargo-pgx = cargo-pgx_0_6_1; }
does not work either, because the build then fails with:
thread 'main' panicked at /build/promscale_extension-0.8.0-vendor.tar.gz/proc-macro2/src/fallback.rs:756:9:
"__mbstate_t_union_(unnamed_at_/nix/store/ij144ma6vs8acil8r9hgr8xkb1dp9azg-glibc-2_39-5-dev/include/bits/types/__mbstate_t_h_16_3)" is not a valid Ident
This seems to be related to [1], which indicates that this is a
problem with newer LLVM / clang toolchains.
At the same time th upstream package is deprecated / archived since
the 2nd of April 2024 [2]. Additionally this package is unfree and
thus very unlikely to be forked. Since we can't expect this to be
fixed, the only sensible thing to do is to remove the package.
[1]: rust-lang/rust-bindgen#2312
[2]: timescale/promscale#1836
pgx had been renamed to pgrx in April 2023 already [1]. Newer versions are already in nixpkgs as pgrx. Since the previous commit removed the only remaining instance of a package still depending on pgx 0.6.1, we can now remove all of buildPgxExtension and cargo-pgx. [1]: pgcentralfoundation/pgrx#1106
wolfgangwalther
force-pushed
the
remove-promscale-pgx
branch
from
04ebb6c
to
a0a1328
Compare
Done! |
marsam
approved these changes
Apr 21, 2024
|
LGTM. Certainly it doesn't make sense providing abandonware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
postgresql14Packages.promscale_extensionbreaks with:However, pinning cargo-pgx to 0.6.1 via the following
does not work either, because the build then fails with:
This seems to be related to rust-lang/rust-bindgen#2312, which indicates that this is a problem with newer LLVM / clang toolchains.
At the same time th upstream package is deprecated / archived since the 2nd of April 2024. Additionally this package is unfree and thus very unlikely to be forked. Since we can't expect this to be fixed, the only sensible thing to do is to remove the package.
Once this package is removed, there is no user of the
buildPgxExtensioninfrastructure left. pgx was renamed to pgrxand we still have newer versions of
pgrxin nixpkgs. So this essentially just removes old, now unused versions.Pinging maintainers for feedback:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.