blendfarm: init at 1.1.6; nixos/blendfarm: init #306516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
gador
force-pushed
the
init-blenderfarm
branch
2 times, most recently
from
da04f4d to
c5630bf
Compare
ofborg
bot
added
8.has: package (new)
pluiedev
suggested changes
May 9, 2024
|
BTW, the title of the PR by convention should look more like `blenderfarm: init at 1.1.6; nixos/blenderfarm: init" or something like that |
gador
changed the title
|
Result of 2 packages blacklisted:
1 package failed to build:
|
pluiedev
suggested changes
May 10, 2024
There was a problem hiding this comment.
Looks like there are some missing dependencies:
error: 1 dependencies of derivation '/nix/store/ax98w9ms9yam8x2g5639ilcraxpp1qa3-review-shell.drv' failed to build
┏━ 1 Errors:
⋮
┃ > libpng12.so.0 -> found: /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm
┃ > libexif.so.12 -> found: /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm
┃ > libfontconfig.so.1 -> found: /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm
┃ > setting RPATH to: /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm
┃ > searching for dependencies of /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm/libpixman-1.so.0
┃ > searching for dependencies of /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm/libexif.so.12
┃ > auto-patchelf: 10 dependencies could not be satisfied
┃ > warn: auto-patchelf ignoring missing libpcre.so.3 wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm/libgl…
┃ > error: auto-patchelf could not satisfy dependency libssl.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blender…
┃ > error: auto-patchelf could not satisfy dependency libgssapi_krb5.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib…
┃ > error: auto-patchelf could not satisfy dependency libicui18n.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/ble…
┃ > error: auto-patchelf could not satisfy dependency libicuuc.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blend…
┃ > warn: auto-patchelf ignoring missing liblzma.so.5 wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blenderfarm/libti…
┃ > error: auto-patchelf could not satisfy dependency libssl.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blender…
┃ > error: auto-patchelf could not satisfy dependency libgssapi_krb5.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib…
┃ > error: auto-patchelf could not satisfy dependency libicui18n.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/ble…
┃ > error: auto-patchelf could not satisfy dependency libicuuc.so wanted by /nix/store/17f6ig92mhhz0wyxc8d8mz0m08jiixka-blenderfarm-1.1.6/lib/blend…
┃ > auto-patchelf failed to find all the required dependencies.
┃ > Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.
┃ For full logs, run 'nix log /nix/store/k3xb7978r226kif4r4zi1jy8yggzr4hr-blenderfarm-1.1.6.drv'.
That is really interessting! |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
1 package built:
|
|
Result of 1 package built:
|
|
Result of 2 packages blacklisted:
1 package built:
|
pluiedev
approved these changes
May 16, 2024
wegank
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1724 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1760 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4161 |
|
Result of 2 packages blacklisted:
1 package built:
|
JohnRTitor
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Is this blendfarm or blenderfarm? According to https://github.com/LogicReinc/LogicReinc.BlendFarm it is the former.
|
Result of 1 package blacklisted:
1 package built:
|
Darn, you're absolutely right. I changed it. Thanks for your review! |
gador
changed the title
JohnRTitor
reviewed
Jul 5, 2024
JohnRTitor
force-pushed
the
init-blenderfarm
branch
from
f6a5d16 to
a0f9023
Compare
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
JohnRTitor
force-pushed
the
init-blenderfarm
branch
from
a0f9023 to
f312bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Init of blendfarm
blendfarmis an "open-source, cross-platform, stand-alone, Network Renderer for Blender".It can support chunking and rendering of still-images as well as animations over the network.
Due to its architecture it needs some workarounds for the client (which is basically the master and has a GUI) and the server (which is a headless worker).
For the server part this PR implements a nixos systemd service which the client can connect to.
The workarounds are necessary due to
blendfarmreading and writing to the directory it is executed from. This can have some undesired sideeffects (such as having renders and setting files in different directories). By adding a custom scriptblendfarm-nixthis is fixed by changing the directory before executing the client.Also
blendfarmwants to download blender on all systems by itself and tries to use this downloaded vanilla version. This obviously doesn't work for nixos. Thereforeblendfarm-nixlinks to blender and installs a version callednix-blender. The server systemd service also installs such anix-blenderversion. By doing so,blendfarmcan use this version on the client and server and both are agreeing on this version.Tested locally on several nixos x86_64-linux machines and VM's.
Still to do: Build and test for darwin.✔️Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.