cargo,clippy,rustc,rustfmt: 1.77.2 -> 1.78.0 #309580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes were made when this patch was committed to rust-next. Most importantly, the minimum rustc version was updated from 1.77.0 to 1.77.1, and if we use the latest version of the patch, we'll be able to cleanly apply the 1.78.0 patch. rust-next gets force pushed sometimes[1], so we shouldn't fetch from it in a FOD, hence we now have rust-1.77-6.8.patch in-tree, but this will save us from having rust-1.78.patch in-tree, which we can fetch from lore. [1]: https://github.com/Rust-for-Linux/linux/activity?ref=rust-next
alyssais
changed the title
alyssais
changed the title
alyssais
requested review from
mweinelt,
Mic92,
zowoq,
winterqt and
figsoda
as code owners
Built. |
13 tasks
|
Is this ready to go? |
|
Yes from my PoV, but since we're between staging cycles anyway, I was holding off on merging in case anybody wanted to review. |
|
I'm not 100% sure how git auto-resolved |
|
sigh the update seems to have broken cross compilation of Rust programs. Bisecting… |
14 tasks
|
|
Fix for cross compilation: #317179 |
13 tasks
|
Potential fix for aarch64-darwin: #317273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I guess we want to hold this until breaking changes are allowed again, since we have packages using nightly features that have been renamed.
Built:
I haven't fixed thunderbirdPackages.thunderbird-102, but it's been marked insecure since September, and I think we should just remove it: #308820.
Could somebody please check fd on x86_64-darwin?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.