Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liboqs: 0.8.0 -> 0.10.0, migrate to by name #310224

Merged
merged 2 commits into from
May 30, 2024
Merged

liboqs: 0.8.0 -> 0.10.0, migrate to by name #310224

merged 2 commits into from
May 30, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented May 8, 2024 •
edited
Loading

Description of changes

  • liboqs: 0.8.0 -> 0.10.0
  • migrate to by name

I faced the issue described in #144170 and fixed it by reverting this commit from upstream which change logic of liboqs.pc generation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request May 8, 2024
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1629

@Sigmanificient Sigmanificient requested a review from xzfc May 12, 2024 23:23
drupol
drupol requested changes May 30, 2024
View reviewed changes
pkgs/by-name/li/liboqs/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/li/liboqs/package.nix Outdated Show resolved Hide resolved
drupol
drupol approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 30, 2024
@drupol drupol merged commit 1b62c5c into NixOS:master May 30, 2024
24 of 25 checks passed
@Sigmanificient Sigmanificient deleted the liboqs-0.10.0 branch May 30, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@NickCao NickCao Awaiting requested review from NickCao

@xzfc xzfc Awaiting requested review from xzfc

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sigmanificient @nixos-discourse @drupol @xzfc @NickCao @tomodachi94