-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webkitgtk[release-17.09]: 2.16.6 -> 2.18.2 #31407
Conversation
Please use |
6983cda
to
d345b43
Compare
@fpletz done |
Well, about target branch being staging-17.09. This PR has conflicts wrt. release-17.09. Perhaps we should first merge it to staging-17.09 or something, so we solve conflicts in this PR already. (Otherwise it's not completely clear what we're merging.) Also note that we don't currently have any jobset for staging-17.09, but we can easily create it if 17.09 managers think so. (EDIT: I personally think it's OK now for 17.09 to merge mass rebuilds directly.) BTW, |
In particular, note that on 17.09 we already have webkitgtk 2.18.1. |
(cherry picked from commit ee0c629)
d345b43
to
41e70e2
Compare
OK, rebased the PR onto |
couldn't find any references to |
Yes, that was just on the old base. |
Well, some pages don't render for me, but this PR doesn't seem to affect the problem, and it's the same on nixos-unstable. I tried epiphany and midori, e.g. google.com is shown just blank grey. Apparently the content is there, as shown by hovering over (invisible) links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't well test it (see my comment), but the change seems OK.
Motivation for this change
We need to keep stable secure.
Things done
Backported commits touching webkitgtk, including the update to 2.18.2, that I recently pushed to staging: ee0c629
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)cc @fpletz