Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapCC, wrapBintools: use absolute paths #314920

Draft
wants to merge 16 commits into
base: staging
Choose a base branch
from
Draft

wrapCC, wrapBintools: use absolute paths #314920

wants to merge 16 commits into from

Commits on Aug 26, 2024

  1. wrapCC, wrapBintools: use absolute paths 

    It is important to use absolute paths to support compiling for different
platforms with the same target prefix (e.g. otherwise identical but
statically linked platform, or enabling some CPU extensions for host
platform that build platform does not support).

For example, it is common to set
```nix
depsBuildBuild = [ buildPackages.stdenv.cc ];
```
and we don’t want to use CC{,_FOR_BUILD} from PATH lookup in such cases.
See also doc/stdenv/cross-compilation.chapter.md.
    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d8f18a9 View commit details
    Browse the repository at this point in the history

  2. gmp: remove C compiler reference from dev output

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    6d4d1fc View commit details
    Browse the repository at this point in the history

  3. glibcCross: fix compiler variables in libgcc 

    C/C++ toolchain variables use absolute paths now, so no need to add
workarounds for these in libgcc.
    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    97d9c0e View commit details
    Browse the repository at this point in the history

  4. gcc: do not reset ld flags when setting dynamic linker 

    This change supresses error when
$bintools/nix-support/libc-ldflags-before file does not exist and also
avoids resetting ld flags when setting dynamic linker (this seems to be
the correct behavior and doesn’t look like it breaks anything else).
    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c040cc9 View commit details
    Browse the repository at this point in the history

  5. gcc: set CFLAGS/CXXFLAGS/LDFLAGS for host platform 

    Discovered by accident when building without strip program that we
actually need these variables to avoid building GCC with debug
information (these variables default to `-g -O2`).

Note that GCC 5 has been removed from Nixpkgs in 20.03 release (see
nixos/doc/manual/release-notes/rl-2003.section.md).
    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    43bfbc9 View commit details
    Browse the repository at this point in the history

  6. musl: avoid $CC reference in wrappers

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    055e8b4 View commit details
    Browse the repository at this point in the history

  7. aiger: fix sed replacements

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    713905d View commit details
    Browse the repository at this point in the history

  8. famistudio: fix escaping CC for sed

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a8f8f42 View commit details
    Browse the repository at this point in the history

  9. openssl: remove $CC reference

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    14de2c5 View commit details
    Browse the repository at this point in the history

  10. ruby: remove bintools reference

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4408cda View commit details
    Browse the repository at this point in the history

  11. tests-stdenv-gcc-stageCompare: cleanup

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2e447c8 View commit details
    Browse the repository at this point in the history

  12. abuild: set strictDeps

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    31be8f7 View commit details
    Browse the repository at this point in the history

  13. python3Packages.clustershell: disable check phase (FIXME, DO NOT MERGE)

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    10a2ccd View commit details
    Browse the repository at this point in the history

  14. fast-downward: remove unnecessary CC/CXX exports 

    These are not needed now that we set CC/CXX to absolute paths.
    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e05e2b1 View commit details
    Browse the repository at this point in the history

  15. bashInteractive: remove CC reference

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    380f165 View commit details
    Browse the repository at this point in the history

  16. icu: remove compiler references

    @tie
    tie committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d6d72d1 View commit details
    Browse the repository at this point in the history