cc-wrapper: Run mktemp before PATH is restored
#316700
Closed
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the wrapper with an empty PATH was failing with `mktemp: command not found`
|
See also #310195 |
13 tasks
IlyaNiklyaev
reviewed
Jun 3, 2024
| # Uses mktemp so should be done before PATH is restored | ||
| if (( "${NIX_CC_USE_RESPONSE_FILE:-@use_response_file_by_default@}" >= 1 )); then | ||
| responseFile=$(mktemp "${TMPDIR:-/tmp}/cc-params.XXXXXX") | ||
| trap 'rm -f -- "$responseFile"' EXIT |
There was a problem hiding this comment.
As I can see trap will run rm from restored PATH. So this approach helps with mktemp, but not with rm.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the wrapper with an empty PATH was failing with
mktemp: command not foundFixes #316674
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.