Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartcat: init at 1.3.0 #320821

Merged
merged 2 commits into from
Jun 22, 2024
Merged

smartcat: init at 1.3.0 #320821

merged 2 commits into from
Jun 22, 2024

Conversation

lpchaim
Copy link
Contributor

@lpchaim lpchaim commented Jun 18, 2024

Description of changes

Adds smartcat, a cat-like tool to interact with large language models on the command line.
I've been looking for a minimal tool to easily work with a locally running ollama instance, and this was a great fit so I figured I'd try my hand at adding it to nixpkgs and maintaining it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 18, 2024
@lpchaim lpchaim changed the title Init smartcat smartcat: init at 1.3.0 Jun 18, 2024
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some feedback below (please amend or squash into the existing commit when applying):

pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Show resolved Hide resolved
pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
@lpchaim
Copy link
Contributor Author

lpchaim commented Jun 18, 2024

Alright, that should do it. Thanks for the pointers!

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gc'd and tested with just this change, this last change seems to be sufficient

pkgs/by-name/sm/smartcat/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good to go, assuming CI has no issues

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 20, 2024
@lpchaim
Copy link
Contributor Author

lpchaim commented Jun 20, 2024

Sweet, this turned out quite a messy first contribution so thanks for your patience!

@Aleksanaa
Copy link
Member

Okay, again...
darwin.apple_sdk.framework.SystemConfiguration

Adds smartcat, a cat-like tool to interact with large language models on
the command line.
I've been looking for a minimal tool to easily work with a locally
running ollama instance, and this was a great fit so I figured I'd try my
hand at adding it to nixpkgs and maintaining it.

Co-authored-by: éclairevoyant <848000+eclairevoyant@users.noreply.github.com>
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 21, 2024
@eclairevoyant eclairevoyant merged commit 6f92eb1 into NixOS:master Jun 22, 2024
25 checks passed
@lpchaim lpchaim deleted the init-smartcat branch June 22, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants