logseq: fix build, move to by-name

[superherointj]

logseq: fix build, move to by-name

CC @Aman9das @bclaud

Proper fix depends on upstream:

• Electron 28 has reached end-of-life logseq/logseq#11378

[bclaud]

Logseq is building and working. But electron 28 reached EOL.

For more information on this issue: logseq/logseq#11378

Thanks @superherointj 🥇

[superherointj]

But electron 28 reached EOL.

I had unpinned electron (30). But then, wegank told me to pin it to upstream. Then, it is EOL.
This has to be fixed at upstream.

Still the process here is correctly defined now.
So it is worth merging as is. (And make a new PR when upstream decides to bump electron.)

[wegank]

Oh, that's too bad, we're not really fixing the build as both Electrons are EOL...

Electron 30 does seem preferable in this case, I think.

[superherointj]

Oh, that's too bad, we're not really fixing the build as both Electrons are EOL...
Electron 30 does seem preferable in this case, I think.

But then, we're not fixing the process. And there's the issue of application not working properly still.
The fix has to come from upstream. We don't have a good fix here.
I'd keep format right and seek a fix at upstream.
Also, whoever wants to still use this package can add the security exception.

I'd favor keeping package right.

@wegank What do we do?

[RobFisher]

I appreciate the work you're doing, @superherointj . Could this explain also logseq/logseq#10851 :

Error: The module '/nix/store/qiv0cgr5l5cl5j8x0wxl267519b2zw3v-logseq-0.10.9/share/logseq/resources/app/node_modules/better-sqlite3/build/Release/better_sqlite3.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 118. This version of Node.js requires
NODE_MODULE_VERSION 119. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

?

btw, in case anyone is wondering, to allow Electron 28:

  nixpkgs.config.permittedInsecurePackages = [
    "electron-28.3.3"
  ];

[superherointj]

Could this explain also logseq/logseq#10851 :

Error: The module '/nix/store/qiv0cgr5l5cl5j8x0wxl267519b2zw3v-logseq-0.10.9/share/logseq/resources/app/node_modules/better-sqlite3/build/Release/better_sqlite3.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 118. This version of Node.js requires
NODE_MODULE_VERSION 119.

I don't use logseq. So I haven't encountered this problem myself. But you can test to pin nodejs to 18:

At nixpkgs, change:

Then test it. If it works, feel free to propose a PR pinning nodejs to 18. And explain the reasoning at nodejs parameter at logseq package file.

Update: This answer is invalid.