Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reveal-md: 5.5.2 -> 6.1.2 #321453

Merged
merged 1 commit into from
Jun 27, 2024
Merged

reveal-md: 5.5.2 -> 6.1.2 #321453

merged 1 commit into from
Jun 27, 2024

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Jun 21, 2024

Description of changes

Update reveal-md to the latest major version.

This version update is fixing PDF print function.

Manually tested:

$ nix shell nixpkgs/nixpkgs-unstable#chromium 

cd <PRESENTATION>

./result/bin/reveal-md presentation.md --print-size A4 --print presentation.pdf --puppeteer-chromium-executable $(which chromium)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@imincik
Copy link
Contributor Author

imincik commented Jun 27, 2024

I am using reveal-md from this PR to write my next conference talk and it looks working very well, including print and PDF export which doesn't work in current version.

@wegank
Copy link
Member

wegank commented Jun 27, 2024

Result of nixpkgs-review pr 321453 run on aarch64-linux 1

1 package built:
  • reveal-md

@wegank wegank merged commit fa63ea4 into NixOS:master Jun 27, 2024
28 checks passed
@imincik
Copy link
Contributor Author

imincik commented Jun 28, 2024

Thanks @wegank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants