Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: replace universal-prefetch-url with nix-prefetch-url #322179

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 24, 2024

It's even less code...

Fixes #321491

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@samueldr
Copy link
Member

Thank you for taking the time to come up with an alternative solution, rather than fishing back a project that would have not had any more maintenance work than it did.

It's even less code...

Co-Authored-By: Yaya <github@uwu.is>
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small fix to remove the nix-universal-prefetch from the nix-shell shebang line. Thanks! 💜

@yayayayaka yayayayaka merged commit 4b72e3c into NixOS:master Jun 26, 2024
25 checks passed
@Mic92 Mic92 deleted the gitlab branch June 26, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitlab update script broken
3 participants