Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfw: add missing substitutions in glfw3 #323510

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

someplaceguy
Copy link
Contributor

Description of changes

This fixes the same issue that #276228 addressed, but in the regular edition instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@someplaceguy
Copy link
Contributor Author

cc @MarcWeber @Twey

This fixes the same issue that NixOS#276228 addressed, but in the regular
edition instead.
@Guanran928
Copy link
Contributor

Skipped orca-slicer and blender, taking too long to build.

Result of nixpkgs-review pr 323510 run on x86_64-linux 1

30 packages marked as broken and skipped:
  • arrayfire
  • chickenPackages_5.chickenEggs.hypergiant
  • cudaPackages.cuda-samples
  • cudaPackages_10.cuda-samples
  • cudaPackages_11.cuda-samples
  • forge
  • libsForQt5.mapbox-gl-native
  • linux-wallpaperengine
  • plasma5Packages.mapbox-gl-native
  • python312Packages.torchrl
  • python312Packages.torchrl.dist
  • tests.cuda.cudaPackages.cuda-samples
  • tests.cuda.cudaPackages_10.cuda-samples
  • tests.cuda.cudaPackages_10_0.cuda-samples
  • tests.cuda.cudaPackages_10_1.cuda-samples
  • tests.cuda.cudaPackages_10_2.cuda-samples
  • tests.cuda.cudaPackages_11.cuda-samples
  • tests.cuda.cudaPackages_11_0.cuda-samples
  • tests.cuda.cudaPackages_11_1.cuda-samples
  • tests.cuda.cudaPackages_11_2.cuda-samples
  • tests.cuda.cudaPackages_11_3.cuda-samples
  • tests.cuda.cudaPackages_11_4.cuda-samples
  • tests.cuda.cudaPackages_11_5.cuda-samples
  • tests.cuda.cudaPackages_11_6.cuda-samples
  • tests.cuda.cudaPackages_11_8.cuda-samples
  • tests.cuda.cudaPackages_12.cuda-samples
  • tests.cuda.cudaPackages_12_0.cuda-samples
  • tests.cuda.cudaPackages_12_1.cuda-samples
  • tests.cuda.cudaPackages_12_2.cuda-samples
  • tests.cuda.cudaPackages_12_3.cuda-samples
3 packages failed to build:
  • icesl
  • python311Packages.shimmy
  • python311Packages.shimmy.dist
84 packages built:
  • _2ship2harkinian
  • bambu-studio
  • bambu-studio.debug
  • blackshades
  • bottles
  • bottles-unwrapped
  • cemu
  • chickenPackages_5.chickenEggs.glfw3
  • cpu-x
  • djv
  • eepers
  • embree
  • embree2
  • esshader
  • famistudio
  • glfw (glfw3)
  • goxel
  • gr-framework
  • heroic
  • hmcl
  • idrisPackages.glfw
  • imgui
  • imgui.lib
  • imhex
  • imnodes
  • imnodes.dev
  • implot
  • io
  • librealsense-gui
  • librealsense-gui.dev
  • libsForQt5.mapbox-gl-qml (plasma5Packages.mapbox-gl-qml)
  • libsForQt5.maplibre-gl-native (plasma5Packages.maplibre-gl-native)
  • mangohud
  • mangohud.doc
  • mangohud.man
  • meshlab
  • midivisualizer
  • mlx42
  • mmlgui
  • monado
  • mujoco
  • opencomposite-helper
  • openmvs
  • openusd
  • pixelnuke
  • portablemc
  • portablemc.dist
  • prismlauncher
  • pure-maps
  • python311Packages.dm-control
  • python311Packages.dm-control.dist
  • python311Packages.glfw
  • python311Packages.glfw.dist
  • python311Packages.mujoco
  • python311Packages.mujoco.dist
  • python311Packages.openusd
  • python311Packages.pymeshlab (python312Packages.pymeshlab)
  • python311Packages.raylib-python-cffi
  • python311Packages.raylib-python-cffi.dist
  • python311Packages.torchrl
  • python311Packages.torchrl.dist
  • python312Packages.glfw
  • python312Packages.glfw.dist
  • python312Packages.mujoco
  • python312Packages.mujoco.dist
  • python312Packages.raylib-python-cffi
  • python312Packages.raylib-python-cffi.dist
  • raylib
  • raylib-games
  • sbclPackages.kons-9
  • sdrpp
  • snekim
  • sony-headphones-client
  • space-station-14-launcher
  • taisei
  • tev
  • tracy
  • tracy-x11
  • vcv-rack
  • vk-bootstrap
  • vk-bootstrap.dev
  • vkdt
  • vlang
  • wlay

@Guanran928
Copy link
Contributor

Guanran928 commented Jul 2, 2024

Hmm, I'm getting Could not initialize GLEW. in vcv-rack
cc @eclairevoyant

❯ results/vcv-rack/bin/Rack
terminate called after throwing an instance of 'rack::Exception'
  what():  Could not initialize GLEW
Aborted (core dumped)

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Jul 2, 2024

vcv-rack was broken anyway, this doesn't make it worse. idk anything about openGL to debug further

@eclairevoyant
Copy link
Contributor

icesl is unfree, and shimmy won't build due to youtube-dl dependency

will take a look at orca-slicer and blender

@eclairevoyant
Copy link
Contributor

Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:
  • chickenPackages_5.chickenEggs.hypergiant
  • libsForQt5.mapbox-gl-native
3 packages failed to build:
  • bambu-studio
  • bambu-studio.debug
  • icesl
73 packages built:
  • _2ship2harkinian
  • blackshades
  • blender
  • blender-hip
  • blendfarm
  • bottles
  • bottles-unwrapped
  • cemu
  • chickenPackages_5.chickenEggs.glfw3
  • cpu-x
  • djv
  • eepers
  • embree
  • embree2
  • envision
  • esshader
  • famistudio
  • glfw (glfw3)
  • goxel
  • gr-framework
  • heroic
  • hmcl
  • imgui
  • imgui.lib
  • imhex
  • imnodes
  • imnodes.dev
  • implot
  • io
  • librealsense-gui
  • librealsense-gui.dev
  • libsForQt5.mapbox-gl-qml
  • libsForQt5.maplibre-gl-native
  • mangohud
  • mangohud.doc
  • mangohud.man
  • meshlab
  • midivisualizer
  • mlx42
  • mmlgui
  • monado
  • mujoco
  • opencomposite-helper
  • openmvs
  • openusd
  • orca-slicer
  • orca-slicer.debug
  • pixelnuke
  • portablemc
  • portablemc.dist
  • prismlauncher
  • pure-maps
  • raylib
  • raylib-games
  • sbclPackages.cl-glfw
  • sbclPackages.cl-glfw3
  • sbclPackages.cl-glfw3-examples
  • sbclPackages.kons-9
  • sdrpp
  • silice
  • snekim
  • sony-headphones-client
  • space-station-14-launcher
  • taisei
  • tev
  • tracy
  • tracy-x11
  • vcv-rack
  • vk-bootstrap
  • vk-bootstrap.dev
  • vkdt
  • vlang
  • wlay

icesl fails due to hash mismatch, and based on the logs bambu-studio doesn't seem like an actual failure but rather an OOM (especially since orca-slicer built fine...)

blender starts and runs fine as well, I think this is okay as-is

@eclairevoyant eclairevoyant merged commit 7f9dba4 into NixOS:master Jul 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants