openssh_{hpn,gssapi}: add backported security fix patches #323768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
added
1.severity: security
13 tasks
Fixes a critical security bug allowing remote code execution as root: <https://www.openssh.com/txt/release-9.8> This may be CVE-2024-6387 (currently embargoed): <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-6387> Thanks to upstream and Sam James <sam@gentoo.org> for the backport: <gentoo/gentoo@1633ef4> Please don’t use these packages on the open internet if you care a lot about security.
emilazy
force-pushed
the
openssh-hpn-gssapi-regresshion
branch
from
9a0d61b to
e215591
Compare
alyssais
approved these changes
Jul 1, 2024
1 task
|
Successfully created backport PR for |
1 task
|
Successfully created backport PR for |
|
What's the need for these patches on OpenSSH 9.8p1? The patches claim to be backports, so I'd have thought they'd only be needed for earlier releases that don't have the full upstream fixes. That is, why is it necessary to have both this change and #323753? |
|
They are not applied to 9.8p1. This PR backports them for non-upstream variants of OpenSSH that have not yet caught up with 9.8p1. |
|
Ah yes, of course! I completely misread the patch. Thank you for explaining. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a critical security bug allowing remote code execution as root: https://www.openssh.com/txt/release-9.8
This may be CVE-2024-6387 (currently embargoed): https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-6387
Thanks to upstream and Sam James for the backport: gentoo/gentoo@1633ef4
Please don’t use these packages on the open internet if you care a lot about security.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.