Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.jaconv: don't use nose #325847

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

dotlambda
Copy link
Member

Description of changes

better version of #325680

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt merged commit 0d7271a into NixOS:master Jul 9, 2024
21 of 23 checks passed
@dotlambda dotlambda deleted the python3Packages.jaconv branch July 9, 2024 15:42
@D3vil0p3r D3vil0p3r added the backport release-24.05 Backport PR automatically label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-325847-to-release-24.05 origin/release-24.05
cd .worktree/backport-325847-to-release-24.05
git switch --create backport-325847-to-release-24.05
git cherry-pick -x c97a3ace23de27a80012cb95db5a55d29ae55fb0 195215f7e048f44b79e8b7dad33cf790dc019af1 75bc8aa03a38155457c72c6d80f8fcb9c25c9b4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants