-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/gotenberg: init #326372
nixos/gotenberg: init #326372
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4230 |
assertions = [ | ||
{ | ||
assertion = cfg.enableBasicAuth -> cfg.environmentFile != null; | ||
message = '' | ||
When enabling HTTP Basic Authentication with `services.gotenberg.enableBasicAuth`, | ||
you must provide an environment file(via `services.gotenberg.environmentFile`) with the appropriate environment variables set in it! | ||
|
||
See `services.gotenberg.enableBasicAuth` for the names of those variables! | ||
''; | ||
} | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im a bit iffy on this assertion. i understand why it's there (as to discourage leaking secrets), but i haven't seen this in many other modules...
i'd welcome it nonetheless, but i think some others commenting on it would be nice
464ebbf
to
59c4021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, good work! Just some little refinements and then we can merge this.
97df536
to
a24fa60
Compare
I quickly pushed the last changes myself to be able to merge this 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two likely oversights we shoudl address with a follow-up PR.
@pyrox0 Another issue you're likely interested in: Happens to me when |
Oddly on latest https://hydra.nixos.org/build/274719893
On a slow PC, it fails for me too, but with another error message:
On a fast PC, it builds:
|
Description of changes
This adds Gotenberg, an API server for file conversions to PDF. It can be used in paperless-ngx, and with the 2.11.0 release, paperless only supports Gotenberg version 8, so it seemed like the right time to package it.
Module tests have been added, as well as release notes entries.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.