Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.yarg: remove nose and modernize #327170

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 14, 2024

Description of changes

Updates the yarg derivation to remove the dependency on nose, and updates the Nix code to follow modern packaging standards. Builds and tests just fine for me.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Jul 14, 2024

It looks like upstream still claims a nose dependency in requirements-test.txt, tox.ini, and runtests.py – I guess it’s vestigal and pytest can handle the orchestration, if you’re sure that the same tests are being run as before this change?

@pyrox0
Copy link
Member Author

pyrox0 commented Jul 14, 2024

It looks like upstream still claims a nose dependency in requirements-test.txt, tox.ini, and runtests.py – I guess it’s vestigal and pytest can handle the orchestration, if you’re sure that the same tests are being run as before this change?

yes, the same tests are still being run, using pytest's nose compatibility layer.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me then!

pkgs/development/python-modules/yarg/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for sending this upstream! Sorry that I can’t merge these myself…

By the way, I only just recently learned about fetchpatch2 and #257446 – if you’re a best‐practices stickler like me then you might be interested in starting to use fetchpatch2 { url = "…?full_index=1"; } for GitHub patches. (But this is absolutely not worth holding up this PR over, given how ubiquitous fetchpatch is already.)

@pyrox0
Copy link
Member Author

pyrox0 commented Jul 14, 2024

I'm very much a stickler for good code and best practices, updated to use fetchpatch2/full_index! I'll keep it in mind for future PRs as well, that's a good thing to know about!

@Aleksanaa
Copy link
Member

@ofborg build python3Packages.yarg

@wegank wegank merged commit 9b25bd0 into NixOS:master Jul 17, 2024
25 of 26 checks passed
@pyrox0 pyrox0 deleted the denose/yarg branch August 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants