-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.yarg: remove nose and modernize #327170
Conversation
It looks like upstream still claims a nose dependency in |
yes, the same tests are still being run, using pytest's nose compatibility layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for sending this upstream! Sorry that I can’t merge these myself…
By the way, I only just recently learned about fetchpatch2
and #257446 – if you’re a best‐practices stickler like me then you might be interested in starting to use fetchpatch2 { url = "…?full_index=1"; }
for GitHub patches. (But this is absolutely not worth holding up this PR over, given how ubiquitous fetchpatch
is already.)
I'm very much a stickler for good code and best practices, updated to use fetchpatch2/full_index! I'll keep it in mind for future PRs as well, that's a good thing to know about! |
@ofborg build python3Packages.yarg |
Description of changes
Updates the yarg derivation to remove the dependency on nose, and updates the Nix code to follow modern packaging standards. Builds and tests just fine for me.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.