Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rinutils: 0.10.2 -> 0.10.3 #327993

Closed
wants to merge 1 commit into from
Closed

rinutils: 0.10.2 -> 0.10.3 #327993

wants to merge 1 commit into from

Conversation

alexshpilkin
Copy link
Member

Description of changes

Mostly just the bugfix for shlomif/rinutils#5, see #144170 and #181875 for details.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alexshpilkin
rinutils: 0.10.2 -> 0.10.3
94054c4 
The bug <shlomif/rinutils#5> in pkg-config
files has been fixed, so remove the workaround.
@AndersonTorres
Copy link
Member

Suggestion: migrate to by-name

@alexshpilkin
Copy link
Member Author

@AndersonTorres Been away from Nixpkgs from a while and missed (the particulars of) that development, it’s very good to see it. Can you give or link a bit of context regarding admonishments not to do manual migrations in some places?

@AndersonTorres
Copy link
Member

The second bullet lightly encourages manual migration in case of version bump.

Manual migrations should only be lightly encouraged if the relevant code is being worked on anyways. For example with a package update or refactoring.

You are free to not do it if you do not want.

But I can cite a small advantage:

Recently we configured a merge bot. It has a very limited scope, but an RFC is being worked on.
The bot can merge pull requests from Ryanbot, given that they are in the by-name hierarchy.

By the way, the bot can be invoked by the command

@NixOS/nixpkgs-merge-bot merge

in a single message.

@alexshpilkin alexshpilkin marked this pull request as draft July 21, 2024 21:58
@alexshpilkin
Copy link
Member Author

Superseded by #326427.

@alexshpilkin alexshpilkin deleted the rinutils-0.10.3 branch July 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexshpilkin @AndersonTorres @NickCao