Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbmp: init at 1.1.1 #329351

Merged
merged 2 commits into from
Nov 11, 2024
Merged

cbmp: init at 1.1.1 #329351

merged 2 commits into from
Nov 11, 2024

Conversation

mrtnvgr
Copy link
Contributor

@mrtnvgr mrtnvgr commented Jul 23, 2024

Description of changes

Closes #261224

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@yunfachi yunfachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also add yourself to the maintainers of this package
https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md

pkgs/by-name/cb/cbmp/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/cb/cbmp/default.nix Outdated Show resolved Hide resolved
@mrtnvgr mrtnvgr force-pushed the cbmp2 branch 2 times, most recently from d9d88ce to d218be5 Compare July 26, 2024 05:10
@SuperSandro2000 SuperSandro2000 merged commit e14a0ae into NixOS:master Nov 11, 2024
10 of 11 checks passed
@mrtnvgr mrtnvgr deleted the cbmp2 branch November 11, 2024 13:09
@mrtnvgr mrtnvgr restored the cbmp2 branch November 11, 2024 13:10
@mrtnvgr mrtnvgr deleted the cbmp2 branch November 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants