Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove maintainer goibhniu #329612

Merged
merged 1 commit into from
Jul 24, 2024
Merged

treewide: remove maintainer goibhniu #329612

merged 1 commit into from
Jul 24, 2024

Conversation

tie
Copy link
Member

@tie tie commented Jul 24, 2024 •
edited
Loading

Description of changes

Inactive in Nixpkgs since 2018 (and a single PR in 2022).
https://github.com/NixOS/nixpkgs/issues?q=author%3Acillianderoiste

Pinging @cillianderoiste (aka goibhniu in maintainer-list.nix).

See #290642

According to grep from #327779, this change leaves 91 packages without maintainer.

List of orphaned packages after this change 
pkgs/applications/audio/a2jmidid/default.nix
pkgs/applications/audio/ams-lv2/default.nix
pkgs/applications/audio/bristol/default.nix
pkgs/applications/audio/calf/default.nix
pkgs/applications/audio/distrho/default.nix
pkgs/applications/audio/drumkv1/default.nix
pkgs/applications/audio/gigedit/default.nix
pkgs/applications/audio/jack-oscrolloscope/default.nix
pkgs/applications/audio/jalv/default.nix
pkgs/applications/audio/lash/default.nix
pkgs/applications/audio/linuxsampler/default.nix
pkgs/applications/audio/mda-lv2/default.nix
pkgs/applications/audio/mhwaveedit/default.nix
pkgs/applications/audio/mid2key/default.nix
pkgs/applications/audio/petrifoo/default.nix
pkgs/applications/audio/qjackctl/default.nix
pkgs/applications/audio/qsampler/default.nix
pkgs/applications/audio/qsynth/default.nix
pkgs/applications/audio/rakarrack/default.nix
pkgs/applications/audio/samplv1/default.nix
pkgs/applications/audio/seq24/default.nix
pkgs/applications/audio/setbfree/default.nix
pkgs/applications/audio/swh-lv2/default.nix
pkgs/applications/audio/synthv1/default.nix
pkgs/applications/audio/vkeybd/default.nix
pkgs/applications/audio/xsynth-dssi/default.nix
pkgs/applications/audio/yoshimi/default.nix
pkgs/applications/graphics/synfigstudio/default.nix
pkgs/applications/misc/artha/default.nix
pkgs/applications/video/simplescreenrecorder/default.nix
pkgs/by-name/qt/qtractor/package.nix
pkgs/development/libraries/aqbanking/default.nix
pkgs/development/libraries/aqbanking/gwenhywfar.nix
pkgs/development/libraries/audio/libsmf/default.nix
pkgs/development/libraries/audio/lilv/default.nix
pkgs/development/libraries/audio/lv2/default.nix
pkgs/development/libraries/audio/lvtk/default.nix
pkgs/development/libraries/audio/qm-dsp/default.nix
pkgs/development/libraries/audio/sratom/default.nix
pkgs/development/libraries/audio/suil/default.nix
pkgs/development/libraries/dbus-cplusplus/default.nix
pkgs/development/libraries/frei0r/default.nix
pkgs/development/libraries/kissfft/default.nix
pkgs/development/libraries/libconfig/default.nix
pkgs/development/libraries/libepoxy/default.nix
pkgs/development/libraries/libfakekey/default.nix
pkgs/development/libraries/libgig/default.nix
pkgs/development/libraries/liblscp/default.nix
pkgs/development/libraries/minixml/default.nix
pkgs/development/libraries/mlt/default.nix
pkgs/development/libraries/movit/default.nix
pkgs/development/libraries/opencolorio/1.x.nix
pkgs/development/libraries/openimageio/default.nix
pkgs/development/libraries/robin-map/default.nix
pkgs/development/libraries/serd/default.nix
pkgs/development/libraries/sord/default.nix
pkgs/development/python-modules/evdev/default.nix
pkgs/development/python-modules/limnoria/default.nix
pkgs/development/python-modules/pathtools/default.nix
pkgs/development/python-modules/rope/default.nix
pkgs/development/python-modules/svg-path/default.nix
pkgs/development/python-modules/virtualenv/default.nix
pkgs/development/python-modules/watchdog/default.nix
pkgs/development/python-modules/zbaemon/default.nix
pkgs/development/python-modules/zc-lockfile/default.nix
pkgs/development/python-modules/zconfig/default.nix
pkgs/development/python-modules/zdaemon/default.nix
pkgs/development/python-modules/zodb/default.nix
pkgs/development/python-modules/zope-component/default.nix
pkgs/development/python-modules/zope-configuration/default.nix
pkgs/development/python-modules/zope-contenttype/default.nix
pkgs/development/python-modules/zope-dottedname/default.nix
pkgs/development/python-modules/zope-event/default.nix
pkgs/development/python-modules/zope-exceptions/default.nix
pkgs/development/python-modules/zope-filerepresentation/default.nix
pkgs/development/python-modules/zope-i18nmessageid/default.nix
pkgs/development/python-modules/zope-interface/default.nix
pkgs/development/python-modules/zope-lifecycleevent/default.nix
pkgs/development/python-modules/zope-location/default.nix
pkgs/development/python-modules/zope-proxy/default.nix
pkgs/development/python-modules/zope-schema/default.nix
pkgs/development/python-modules/zope-size/default.nix
pkgs/development/python-modules/zope-testing/default.nix
pkgs/development/python-modules/zope-testrunner/default.nix
pkgs/misc/jackaudio/default.nix
pkgs/os-specific/linux/xf86-video-nested/default.nix
pkgs/servers/http/yaws/default.nix
pkgs/tools/misc/ttfautohint/default.nix
pkgs/tools/security/aespipe/default.nix
pkgs/tools/text/podiff/default.nix
pkgs/tools/text/uni2ascii/default.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nodejs 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jul 24, 2024
@cillianderoiste
Copy link
Member

Thanks for cleaning that up!

@tie tie marked this pull request as ready for review July 24, 2024 09:45
jopejoe1
jopejoe1 previously requested changes Jul 24, 2024
View reviewed changes
pkgs/applications/audio/lmms/default.nix Outdated Show resolved Hide resolved
@tie tie force-pushed the remove-goibhniu branch 2 times, most recently from f5f5e8a to 2a2ce6d Compare July 24, 2024 10:33
@tie tie requested a review from jopejoe1 July 24, 2024 11:00
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 24, 2024
@Aleksanaa Aleksanaa merged commit 8f56c28 into NixOS:master Jul 24, 2024
24 checks passed
@tie tie deleted the remove-goibhniu branch July 24, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@jopejoe1 jopejoe1 Awaiting requested review from jopejoe1

Assignees
No one assigned
Labels
6.topic: nodejs 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tie @cillianderoiste @drupol @jopejoe1 @Aleksanaa