python311Packages.yanc: drop #329978
Merged
python311Packages.yanc: drop #329978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigmanificient
changed the title
|
CI is failling with:
|
emilazy
requested changes
Jul 26, 2024
There was a problem hiding this comment.
This is a post‐processor for nose output. It doesn’t make any sense to try and fix it in the process of removing nose. Instead, it should be removed.
The only reverse dependency in‐tree is python3Packages.preggy. It looks like it should work fine with a simple pytestCheckHook instead.
Sigmanificient
changed the title
natsukium
reviewed
Jul 27, 2024
|
Result of 2 packages built successfully:
|
emilazy
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove nose tests which are disable for python > 3.5, long EOL.
Part of:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.