Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.tempita: drop nose dependency #330004

Closed
wants to merge 1 commit into from

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024

Description of changes

part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a 2021 upstream release that seems to support Python 3, maybe we should switch to that rather than using this random fork if we want to keep this package?

However, the only reverse dependency in‐tree is python3Packages.sqlalchemy-migrate, which is marked broken because it doesn’t support newer SQLAlchemy versions. Perhaps we should simply drop instead.

@Sigmanificient
Copy link
Member Author

The bit-bucket link in repo description seems to 404 on my side, which might be te reason the fork was chosen
Well, the fact has no maintainers is an argument in favor of dropping it?

@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

Ah, the thing from 2021 is just a wheel of a version from 2013. Weird.

I favour dropping this and sqlalchemy-migrate. I was going to cite the small list of reverse dependencies on Wheelodex that I remembered seeing when I left my last comment but it looks like I made the site fall over by using it too much.

However, openlp depends on sqlalchemy-migrate. It is on an outdated version, and the latest upstream release does not use the dependency any more. So we’d have to bump that, or drop the package, which would be unfortunate as it seems like an actively‐maintained end‐user application.

@jorsn Would you be willing to update openlp to help unblock this?

@mweinelt
Copy link
Member

  • sqlalchemy-migrate has been marked broken ever since we moved to 3.11 898955e
  • qtwebkit was marked vulnerable in 2022/11 a505704
  • openlp hasn't been updated once since it was introduced in 2020

I think it is safe to remove, since nobody cared about its dependency chain being broken and vulnerable.

@Sigmanificient
Copy link
Member Author

Doesn't qtwebkit have quite a few deps?

@emilazy
Copy link
Member

emilazy commented Jul 29, 2024

It has a handful, but ~nobody can use them, because Hydra won’t build insecure packages and anyone who overrides that warning to build an insecure unmaintained web browser engine themselves can just maintain it out-of‐tree if they really want to. They should all be updated or removed, basically (probably removed, since it means nobody has noticed they’re broken or stepped up to maintain them since).

Closing in favour of #330855, but thank you!

@emilazy emilazy closed this Jul 29, 2024
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 29, 2024

rip small pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants