Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.sampledata: drop #330029

Merged
merged 1 commit into from
Jul 27, 2024
Merged

python312Packages.sampledata: drop #330029

merged 1 commit into from
Jul 27, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024 •
edited
Loading

Description of changes

part of: #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient force-pushed the sampledata branch 2 times, most recently from eb235d1 to 1a97585 Compare July 25, 2024 22:47
@emilazy emilazy mentioned this pull request Jul 26, 2024
Closed
emilazy
emilazy requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unmaintained for 7 years, not a single reverse dependency on PyPI, let’s just drop this.

@Sigmanificient
Copy link
Member Author

How do you compute rev deps?

@emilazy
Copy link
Member

emilazy commented Jul 26, 2024

Wheelodex for PyPI, rg '\bpackage-name\b' for Nixpkgs direct reverse dependencies, @trofi’s arevdeps.nix for Nixpkgs transitive reverse dependencies.

@Sigmanificient
Copy link
Member Author

How dropping it caused a merge conflict 😅

@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

Looks good; please fix the commit and PR messages.

@Sigmanificient Sigmanificient changed the title python312Packages.sampledata: drop nose dependency; fix tests python312Packages.sampledata: drop Jul 27, 2024
@Sigmanificient
python312Packages.sampledata: drop
4355075 
python312Package.sampledata: drop
@natsukium
Copy link
Member

Result of nixpkgs-review pr 330029 at 4355075 run on x86_64-linux 1

natsukium
natsukium approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@emilazy emilazy merged commit 20cbf21 into NixOS:master Jul 27, 2024
8 of 9 checks passed
@Sigmanificient Sigmanificient deleted the sampledata branch July 27, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@natsukium natsukium natsukium approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sigmanificient @emilazy @natsukium