Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.pygatt: drop nose #330688

Closed
wants to merge 1 commit into from
Closed

python312Packages.pygatt: drop nose #330688

wants to merge 1 commit into from

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 28, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Jul 28, 2024
Closed
@ofborg ofborg bot requested a review from fabaff July 28, 2024 19:47
emilazy
emilazy requested changes Jul 28, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work on upstreaming this!

pkgs/development/python-modules/pygatt/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pygatt/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pygatt/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pygatt/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pygatt/default.nix Outdated Show resolved Hide resolved
@emilazy
Copy link
Member

emilazy commented Jul 28, 2024

Oh, also, typo: “gygatt”.

@Sigmanificient Sigmanificient changed the title python312Packages.gygatt: 4.0.5 -> 4.0.5-unstable-2021-09-13, drop nose python312Packages.pygatt: 4.0.5 -> 4.0.5-unstable-2021-09-13, drop nose Jul 29, 2024
@Sigmanificient
Copy link
Member Author

Will wait for fabaff, mweinelt & emilazy to agree on a final answer 😅

@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

Pending on rebase and review comments.

@Sigmanificient Sigmanificient changed the title python312Packages.pygatt: 4.0.5 -> 4.0.5-unstable-2021-09-13, drop nose python312Packages.pygatt: drop nose Aug 10, 2024
@Sigmanificient Sigmanificient mentioned this pull request Aug 10, 2024
Merged
13 tasks
@emilazy
Copy link
Member

emilazy commented Aug 10, 2024

Handled by #332660. Thanks for getting the patch upstreamed!

@emilazy emilazy closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@emilazy emilazy Awaiting requested review from emilazy

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sigmanificient @emilazy @fabaff @mweinelt