-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.python-hglib: Remove nose dependency; modernize #330739
Conversation
c82c93a
to
0104528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you! Just a couple nits.
0104528
to
d4b2b01
Compare
d4b2b01
to
43a5b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 330739
run on aarch64-linux 1
21 packages built:
- mozillavpn
- mozphab
- mozphab.dist
- powerline (python312Packages.powerline)
- powerline.dist (python312Packages.powerline.dist)
- python311Packages.glean-parser
- python311Packages.glean-parser.dist
- python311Packages.glean-sdk
- python311Packages.glean-sdk.dist
- python311Packages.powerline
- python311Packages.powerline.dist
- python311Packages.python-hglib
- python311Packages.python-hglib.dist
- python312Packages.glean-parser
- python312Packages.glean-parser.dist
- python312Packages.glean-sdk
- python312Packages.glean-sdk.dist
- python312Packages.python-hglib
- python312Packages.python-hglib.dist
- sourcehut.hgsrht
- sourcehut.hgsrht.dist
I assume the |
Yes, it uses the lmdb-rkv-sys crate |
Do you know if we can easily get it to use the system |
I'm not sure, as I've never used the crate before, and I'm not familiar with rust development. I'll look into it, but no guarantees that I can get anything working lol |
Description of changes
Part of #326513
This required a few more patches and fixes to other packages than I would like, but this does allow all dependents of python-hglib to build and test properly.
Updates:
Changes:
mozphab
has 3 failing tests disabledThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.