-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.inotify: drop nose dependency; modernize #330776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not personally using it, though maybe there are others that are |
I have never used |
3bcbdc3
to
9a61d4d
Compare
9a61d4d
to
96eb0d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your great work on this project; we couldn’t have done it without you and it looks like we’re on track to remove nose for 24.11 :) I’m looking into the remaining two packages without open PRs, but if I don’t get around to it in the next day or two you can feel free to pick them up if you feel like it.
Description of changes
Part of #326513
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.