Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.inotify: drop nose dependency; modernize #330776

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 29, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pyrox0 pyrox0 changed the title python312Packages.inotify: drop nose dependency python312Packages.inotify: drop nose dependency; modernize Jul 29, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like upstream is pretty dead. The only user of this in‐tree is lxd-image-server, which hasn’t been updated since it was first added, but it does have a NixOS module…

@mkg20001 @aanderse Hi! Do you still use lxd-image-server? Is it still relevant in the Incus era?

@aanderse
Copy link
Member

not personally using it, though maybe there are others that are

cc @adamcstephens

@adamcstephens
Copy link
Contributor

I have never used lxd-image-server, but assuming it works with LXD I would expect it to work with Incus. They share the same remote image protocol.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your great work on this project; we couldn’t have done it without you and it looks like we’re on track to remove nose for 24.11 :) I’m looking into the remaining two packages without open PRs, but if I don’t get around to it in the next day or two you can feel free to pick them up if you feel like it.

@emilazy emilazy merged commit ffa6a78 into NixOS:master Oct 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants