Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvmfr: backport security patch for potential buffer overflow & build fix for linux_6_10 #331206

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

j-brn
Copy link
Member

@j-brn j-brn commented Jul 31, 2024

Description of changes

Things done

  • kvmfr: added a patch for kvmfr from the upstream repo to fix the build for linux

  • looking-glass-client: replaced an already included patch from upstream with fetchpatch

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.


Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@Naxdy Naxdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel module builds.

@Svenum
Copy link

Svenum commented Aug 19, 2024

I am waiting for this. Any news?

@j-brn
Copy link
Member Author

j-brn commented Aug 21, 2024

I am waiting for this. Any news?

Just waiting for someone to merge it. The change is ready to use, I'm already using the updated derivation with an overlay.

@Svenum
Copy link

Svenum commented Aug 21, 2024

Ok, i have build an overlay yesterday too

@thedaringdev
Copy link
Contributor

Waiting on this aswell

@Svenum
Copy link

Svenum commented Aug 21, 2024

Waiting on this aswell

Here is my Overlay. Works great for me

  final: prev: {                                   
    linuxPackages_latest = prev.linuxPackages_latest.extend (kfinal: kprev: {                                   
      kvmfr = prev.linuxPackages_latest.kvmfr.overrideAttrs (old: {                                   
        patches = [                                   
          (prev.fetchpatch {                                   
            url = "https://github.com/gnif/LookingGlass/commit/7305ce36af211220419eeab302ff28793d515df2.patch";                                   
            hash = "sha256-97nZsIH+jKCvSIPf1XPf3i8Wbr24almFZzMOhjhLOYk=";                                   
            stripLen = 1;                                   
          })                                   
        ];                                   
      });                                   
    });                                   
                                     
    looking-glass-client = prev.looking-glass-client.overrideAttrs (old: {                                   
      patches = [                                   
        (prev.fetchpatch {                                   
          url = "https://github.com/gnif/LookingGlass/commit/20972cfd9b940fddf9e7f3d2887a271d16398979.patch";                                   
          hash = "sha256-CqB8AmOZ4YxnEsQkyu/ZEaun6ywpSh4B7PM+MFJF0qU=";                                   
          stripLen = 1;                                   
        })                                   
      ];                                   
    });

@j-brn j-brn changed the title kvmfr: fix build for linux-6_10; looking-glass-client: remove patchfile in favor of fetchpatch kvmfr: backport security patch for potential buffer overflow & build fix for linux_6_10 Aug 29, 2024
@j-brn
Copy link
Member Author

j-brn commented Aug 29, 2024

Added another patch that fixes a potential buffer overflow vulnerability reported in gnif/LookingGlass#1133

@j-brn j-brn requested a review from Naxdy August 29, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants