Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yazi, yazi-unwrapped: 0.2.5 -> 0.3.0 #331563

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Aug 1, 2024

Description of changes

https://github.com/sxyazi/yazi/releases/tag/v0.3.0, sxyazi/yazi#1046 (comment).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman
Copy link
Contributor

Result of nixpkgs-review pr 331563 run on x86_64-linux 1

2 packages built:
  • yazi
  • yazi-unwrapped

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I need to update my config a bit from breaking changes. But, LGTM.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 331563 run on aarch64-darwin 1

2 packages built:
  • yazi
  • yazi-unwrapped

@matthiasbeyer matthiasbeyer merged commit f4b4f1b into NixOS:master Aug 1, 2024
30 of 32 checks passed
@uncenter uncenter deleted the pr-1de45257 branch August 1, 2024 20:16
khaneliman added a commit to khaneliman/khanelinix that referenced this pull request Aug 1, 2024
@teto
Copy link
Member

teto commented Aug 5, 2024

havent had the chance to test it but thanks for updating it. New version looks dope.
would be cool to unvendor lua as it is apparently possible: sxyazi/yazi#1046 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants