python3Packages.scikit-network: init at 0.33.0 #336136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-heiss
suggested changes
Aug 20, 2024
There was a problem hiding this comment.
- the three commits 7988c47faf346d440d74f73c440d20624c812f3b, 706dc4f8e4542bac75f9de94ce7be6a16595adb0 and afd3fc24dc071af6586aa82f3d7a3c19a160b90f should be squashed together
- package needs an entry in
pkgs/top-level/python-packages.nix - the title of the commit introducing the package should be
python3Packages.scikit-network: init at 0.33.0
|
@ofborg eval |
SimShady
force-pushed
the
add-python-package-scikit-network
branch
from
afd3fc2
to
73f9752
Compare
SimShady
force-pushed
the
add-python-package-scikit-network
branch
2 times, most recently
from
e909864
to
706e860
Compare
There was a problem hiding this comment.
Also, while building the package is fine, afterwards trying to import it I get an error:
```
>>> import sknetwork
Traceback (most recent call last):
File "", line 1, in
File "/nix/store/fwf4hxkg3nwmdk2n49z6i9cixl7njigc-python3.12-scikit-network-0.33.0/lib/python3.12/site-packages/sknetwork/__init__.py", line 9, in
import sknetwork.topology
File "/nix/store/fwf4hxkg3nwmdk2n49z6i9cixl7njigc-python3.12-scikit-network-0.33.0/lib/python3.12/site-packages/sknetwork/topology/__init__.py", line 2, in
from sknetwork.topology.cliques import count_cliques
ModuleNotFoundError: No module named 'sknetwork.topology.cliques'
```
Edit 27-09-2024: This was a fsck-up from my site; apparently python3.11 inside the nixpkgs-review sets the search path wrong for the modules. Now verified the import with both 3.11 and 3.12, both work totally fine!
Thus: LGTM!
drupol
changed the title
natsukium
reviewed
Aug 21, 2024
SimShady
force-pushed
the
add-python-package-scikit-network
branch
from
706e860
to
4ddaa30
Compare
SimShady
force-pushed
the
add-python-package-scikit-network
branch
from
4ddaa30
to
df2e781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added python package
scikit-networkThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.