Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.clustershell: drop nose dependency #336158

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Aug 20, 2024

Description of changes

Couldn't get it to work with pytestCheckHook

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member

It wants to import distuitls. Try adding setuptools.

@Sigmanificient
Copy link
Member Author

works with build-system = [ setuptools distutils ];

@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

Result of nixpkgs-review pr 336158 run on aarch64-linux 1

4 packages built:
  • python311Packages.clustershell
  • python311Packages.clustershell.dist
  • python312Packages.clustershell
  • python312Packages.clustershell.dist

@emilazy emilazy merged commit e0d069b into NixOS:master Sep 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants