Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.stdenv: Easier to override stdenv #336837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Artturin
Copy link
Member

also getting rid of pkgsStructuredAttrs because tests for the whole
structuredAttrs dependency tree don't belong here and should be split
in to a different test.

also getting rid of `pkgsStructuredAttrs` because tests for the whole
`structuredAttrs` dependency tree don't belong here and should be split
in to a different test.
@Artturin Artturin changed the base branch from master to staging-next August 23, 2024 19:28
@Artturin
Copy link
Member Author

Rebased to staging-next because there were incoming conflicts

@Artturin Artturin force-pushed the teststdenvhookesieroverriding branch from 327aa01 to 76d0f11 Compare August 23, 2024 19:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 23, 2024
@SomeoneSerge SomeoneSerge self-requested a review August 23, 2024 20:14
@vcunat vcunat changed the base branch from staging-next to master August 31, 2024 09:51
@Artturin
Copy link
Member Author

@ofborg build tests.stdenv

bootStdenv = stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv;
pkgsStructured = import pkgs.path { config = { structuredAttrsByDefault = true; }; inherit (stdenv.hostPlatform) system; };
bootStdenvStructuredAttrsByDefault = pkgsStructured.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv;
bootStdenv = if stdenvHasBootPackages then stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv else stdenv;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seaprate pr should make it so we use longestValidPathPrefix and attrByPath here to support darwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant