Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3{11,12}Packages.jupyter-contrib-nbextensions: drop #343797

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Sep 22, 2024

Description of changes

This is marked as broken already because of a Jupyter Notebook upgrade, and the upstream repository hasn’t been touched in two years, so there’s little reason to try doing anything about its nose dependency. Other distributions have already dropped this package; there’s a patch from an openSUSE maintainer to migrate it off nose, but they don’t seem to package it any more.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is marked as broken already because of a Jupyter Notebook upgrade,
and the upstream repository hasn’t been touched in two years,
so there’s little reason to try doing anything about its nose
dependency. Other distributions have already dropped this package;
there’s a patch from an openSUSE maintainer to migrate it off nose,
but they don’t seem to package it any more.
@github-actions github-actions bot added 6.topic: python 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Sep 22, 2024
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for handling this :)

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 343797 run on x86_64-linux 1

@SuperSandro2000 SuperSandro2000 merged commit cf61311 into NixOS:master Sep 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants