JDK updates and removals #344544

emilazy · 2024-09-25T23:03:06Z

Description of changes

OpenJDK 23 is out, and 22 is end‐of‐life. This packages the new version for OpenJDK source builds, Temurin, and Zulu. I opted to drop the old versions entirely because these non‐LTS releases get released and go EOL every 6 months anyway so I don’t think it makes sense to carry around old derivations marked as insecure for versions with such short shelf lives. Sadly a few things aren’t ready for 23 yet (e.g. because of using the abandoned string template preview proposal), and have been marked as broken.

Some general thoughts on Nixpkgs JDK packaging from an outsider:

OpenJDK source, Temurin, Semeru, Zulu, and Corretto feels like a needlessly high number of JDK distributions to me. Semeru has OpenJ9 and source builds have obvious value. I don’t see a good reason for us to have both Temurin and Zulu. It seems like we use Zulu on Darwin because it supports JavaFX and supports aarch64-darwin further back than Temurin does (because Temurin relies on upstream OpenJDK which hasn’t backported aarch64-darwin support to JDK 8). I think if we could get the OpenJDK/OpenJFX source builds working on Darwin and bootstrap them from Temurin it would be a nicer situation overall; not supporting JDK 8 on aarch64-darwin seems okay. Zulu is pretty neglected, given its tedious manual update process; every Zulu JDK was out of date. If we stop using it on Darwin, I think it could reasonably be removed. (Switching from Temurin to Zulu for bootstrap might also be an option, if the derivation can be made more maintainable.) I’m not sure about the motivation for carrying Corretto; cc @rollf?
8, 11, 17, 21, and the latest version is… also a lot of versions to deal with. Backporting FFmpeg changes to old OpenJFXes was fairly painful. At least 8 will go EOL within the next couple years…
There’s way too much copy and paste. The OpenJDK and OpenJFX derivations need deduplicating across versions, Temurin and Semeru are copy‐pasted from each other, the Linux and Darwin derivations of those could probably be deduplicated somewhat… if I end up looking at getting OpenJDK to build on Darwin I might try and do something about the duplication there.

Things done

Add a 👍 reaction to pull requests you find important.

emilazy · 2024-09-25T23:19:16Z

Not going to fix the nixpkgs-vet warning given that it would result in inconsistency with all the other Zulu versions (and the Zulu packaging pattern wouldn’t work with pkgs/by-name anyway). Not going to fix the formatting warning for similar reasons (consistency with the other versions is more important; if I deduplicate the expressions then I’ll format it then).

Infinidoge · 2024-09-26T03:28:20Z

pkgs/top-level/aliases.nix

@@ -1163,8 +1163,13 @@ mapAliases {
  openjdk20_headless = openjdk20; # Added 2024-08-01
  jdk20 = openjdk20; # Added 2024-08-01
  jdk20_headless = openjdk20; # Added 2024-08-01
+  openjdk22 = throw "OpenJDK 22 was removed as it has reached its end of life"; # Added 2024-09-24
+  openjdk22_headless = openjdk20; # Added 2024-09-24


Suggested change

openjdk22_headless = openjdk20; # Added 2024-09-24

openjdk22_headless = openjdk22; # Added 2024-09-24

Whoops; fixed.

Infinidoge · 2024-09-26T03:31:44Z

The OpenJDK 22 files still seem to be in the repository, might be an oversight.

rollf · 2024-09-26T04:22:23Z

@emilazy Thank your for your feedback.

I have integrated Corretto because it is used in my organization. Several other people had requested it in the past. Several people have expressed the need for corretto on Darwin which currently doesn't exist. Here is a non-working/draft PR for some context.

In my case, the build infrastructure locks down the used Java version (via gradle, vendor = JvmVendorSpec.AMAZON) so I could not build anything (on NixOS) without removing that condition (and using OpenJDK).

One thing I'd like to explore in the future is separate the corretto build from the OpenJDK builds. Currently, mk-corretio.nix overridesAttributes on the corresponding JDK build. I think (now) that this is needlessly binding the two projects.

thiagokokada · 2024-09-26T07:55:01Z

OpenJDK source, Temurin, Semeru, Zulu, and Corretto feels like a needlessly high number of JDK distributions to me.

I concur, unless there is a maintainer committed to maintaining those variations I would also be in favor of just removing them as much as possible. Otherwise they will just bit rot (e.g. stop building) or be a security issue since they get terrible out of date.

In my opinion we need to maintain the minimal amount of JDKs possible: so if we need e.g. Zulu JDK8 to bootstrap other JDK for Darwin let's just keep that specific version (this is an example, not sure how Darwin bootstrap works). And ideally keep only OpenJDK as the way to go for Java here in nixpkgs.

rollf · 2024-09-26T09:06:50Z

I concur, unless there is a maintainer committed to maintaining those variations I would also be in favor of just removing them as much as possible. Otherwise they will just bit rot (e.g. stop building) or be a security issue since they get terrible out of date.

I am committed to maintain Corretto on Linux. I use this daily. I have updated it regularly (here is my latest approved-but-not-merged-PR).

Tungsten842 · 2024-09-26T10:04:56Z

I believe that jdk21, jdk17, jdk11 and jdk8 require an update as well. For each of these a new version is available, and they have not been updated in quite a while.

emilazy · 2024-09-26T10:11:08Z

The OpenJDK 22 files still seem to be in the repository, might be an oversight.

Yeah, rebase calamity. Fixed.

I have integrated Corretto because it is used in my organization. Several other people had requested it in the past. Several people have expressed the need for corretto on Darwin which currently doesn't exist. Here is a non-working/draft PR for some context.

In my case, the build infrastructure locks down the used Java version (via gradle, vendor = JvmVendorSpec.AMAZON) so I could not build anything (on NixOS) without removing that condition (and using OpenJDK).

Fair enough. It’s a bit weird to me that people are pinning requirements for what are, to my understanding, basically builds of the same source code with a handful of patches on top, but clearly there’s some benefit to having it. Since they only ship LTS releases and you’re keeping it cared for, it didn’t cause me any maintenance burden here, and so I have no particular motivation to push for its removal :) Thanks for putting in the maintenance work.

In my opinion we need to maintain the minimal amount of JDKs possible: so if we need e.g. Zulu JDK8 to bootstrap other JDK for Darwin let's just keep that specific version (this is an example, not sure how Darwin bootstrap works). And ideally keep only OpenJDK as the way to go for Java here in nixpkgs.

Using Zulu to bootstrap our source OpenJDK 8 on aarch64-darwin wouldn’t help that much, as the OpenJDK 8 source itself needs extensive patching to work with that platform. There are public patches for this, to my understanding, but it seems like upstreaming them has stalled out. I don’t think we should try and maintain a port of a version that is going to be EOL in a year or two to aarch64-darwin ourselves. We should just pick one of Temurin or Zulu, use it for bootstrap of source OpenJDKs, ship the source build on all platforms, and let jdk8 be broken on aarch64-darwin, as it is upstream.

In fact, I would personally lean towards just dropping JDK 8 sooner. Debian already has, for instance.

I believe that jdk21, jdk17, jdk11 and jdk8 require an update as well. For each of these a new version is available, and they have not been updated in quite a while.

And this is why shipping five versions of the JDK with the maintainer resources we seem to have is a pain…

I’ll see if I can bump them.

thiagokokada · 2024-09-26T10:30:11Z

Using Zulu to bootstrap our source OpenJDK 8 on aarch64-darwin wouldn’t help that much, as the OpenJDK 8 source itself needs extensive patching to work with that platform. There are public patches for this, to my understanding, but it seems like upstreaming them has stalled out. I don’t think we should try and maintain a port of a version that is going to be EOL in a year or two to aarch64-darwin ourselves. We should just pick one of Temurin or Zulu, use it for bootstrap of source OpenJDKs, ship the source build on all platforms, and let jdk8 be broken on aarch64-darwin, as it is upstream.

Oh no, I didn't mean to build OpenJDK 8 for aarch64-darwin from Zulu 8, that was an example (e.g.: if we need any JDK8 to bootstrap the remaining OpenJDK versions that we care, we could use Zulu 8 and keep only that in nixpkgs, dropping the other versions). I completely agree that we should not care about having a working OpenJDK 8 build for aarch64-darwin, unless there is official support in upstream.

In fact, I would personally lean towards just dropping JDK 8 sooner. Debian already has, for instance.

That I am not completely sure. If there is no packages in nixpkgs that depends on JDK 8 I think it is fine, but there are probably some users of Java 8 out there. I don't think there are a lot of them though, but it is difficult to have any idea of package usage in nixpkgs.

Pin the latest LTS version for consistency with OpenJDK.

emilazy · 2024-09-26T11:23:44Z

configure: error: "ga" is not a valid numerical value for VERSION_BUILD

Sigh.

pkgs/development/compilers/openjdk/17.nix

emilazy · 2024-09-26T14:14:57Z

(Oops, I forgot to post this.)

Oh no, I didn't mean to build OpenJDK 8 for aarch64-darwin from Zulu 8, that was an example (e.g.: if we need any JDK8 to bootstrap the remaining OpenJDK versions that we care, we could use Zulu 8 and keep only that in nixpkgs, dropping the other versions). I completely agree that we should not care about having a working OpenJDK 8 build for aarch64-darwin, unless there is official support in upstream.

I think we bootstrap all versions from an equal Temurin version now, so bootstrap shouldn’t be an issue. The Temurin 8 x86_64-darwin binary can be used on Apple Silicon at a pinch, too.

That I am not completely sure. If there is no packages in nixpkgs that depends on JDK 8 I think it is fine, but there are probably some users of Java 8 out there. I don't think there are a lot of them though, but it is difficult to have any idea of package usage in nixpkgs.

Yeah, there’s some reverse dependencies. But I have a very particular set of skills. We are, in any case, going to have to deal with the situation once EOL happens.

emilazy · 2024-09-26T14:34:56Z

All the builds went through. This should be ready, modulo version stuff.

This requires Java 21 but OpenJFX ≥ 22. As OpenJFX 22 is EOL, we use OpenJFX 23, which technically only supports down to JDK 21, but let’s hope for the best.

Actually, nobody even got around to making an alias for this one…

thiagokokada

LGTM.

thiagokokada · 2024-09-26T19:42:03Z

Eval error, can you take a look @emilazy?

thiagokokada · 2024-09-27T09:16:28Z

@ofborg eval

thiagokokada · 2024-09-27T13:55:54Z

Eval error, can you take a look @emilazy?

Seems to be a transient issue. @ofborg eval worked.

emilazy requested review from edwtjo, thiagokokada and Infinidoge September 25, 2024 23:03

ofborg bot added 8.has: clean-up 8.has: package (new) labels Sep 26, 2024

ofborg bot requested review from abbradar, lucasbergman, jlesquembre, bachp and SharzyL September 26, 2024 02:29

ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 501-1000 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels Sep 26, 2024

Infinidoge reviewed Sep 26, 2024

View reviewed changes

emilazy force-pushed the push-sskpuxzxzrow branch from 8ce2409 to ee4f58c Compare September 26, 2024 10:03

emilazy force-pushed the push-sskpuxzxzrow branch from ee4f58c to f74441c Compare September 26, 2024 10:48

ofborg bot requested a review from Infinidoge September 26, 2024 10:53

emilazy force-pushed the push-sskpuxzxzrow branch from f74441c to e61a160 Compare September 26, 2024 10:55

emilazy added 3 commits September 26, 2024 11:58

temurin-{,jre-}bin: temurin-{,jre-}bin-22 -> temurin{,jre-}bin-21

ff4d69b

Pin the latest LTS version for consistency with OpenJDK.

temurin-{,jre-}bin-{8,11,17,21,22}: update

6da99f2

temurin-{,jre-}bin-23: init at 23.0.0

3da3ed0

emilazy force-pushed the push-sskpuxzxzrow branch from e61a160 to 4383a5e Compare September 26, 2024 10:59

emilazy force-pushed the push-sskpuxzxzrow branch 2 times, most recently from 9f01c7b to e903e86 Compare September 26, 2024 11:46

thiagokokada approved these changes Sep 26, 2024

View reviewed changes

thiagokokada reviewed Sep 26, 2024

View reviewed changes

pkgs/development/compilers/openjdk/17.nix Outdated Show resolved Hide resolved

emilazy added 11 commits September 26, 2024 16:45

openjdk11: 11.0.23+9 -> 11.0.24+8

0a94520

openjdk17: 17.0.11+9 -> 17.0.12+7

64e24d1

openjdk21: 21.0.3+9 -> 21.0.4+7

fac90a7

{openjdk,openjfx}23: init at 23-ga

00a8a1c

jextract: pin JDK 23, mark as broken

81c3d76

cryptomator: pin JDK 23, mark as broken

092c108

moneydance: pin OpenJDK 23

56d6fe1

jabref: pin JDK 21 and OpenJFX 23

b32d2c0

This requires Java 21 but OpenJFX ≥ 22. As OpenJFX 22 is EOL, we use OpenJFX 23, which technically only supports down to JDK 21, but let’s hope for the best.

zulu22: drop

35cc147

Actually, nobody even got around to making an alias for this one…

{openjdk,openjfx}22: drop

732642b

temurin-{,jre-}bin-22: drop

d19c7e8

emilazy force-pushed the push-sskpuxzxzrow branch from e903e86 to d19c7e8 Compare September 26, 2024 15:55

thiagokokada approved these changes Sep 26, 2024

View reviewed changes

wegank added the 12.approvals: 1 label Sep 26, 2024

thiagokokada merged commit 371963e into NixOS:staging Sep 27, 2024
21 of 23 checks passed

emilazy deleted the push-sskpuxzxzrow branch September 27, 2024 16:46

qubitnano mentioned this pull request Sep 29, 2024

Update request: jdk 21 → 23 #345220

Open

1 task

emilazy mentioned this pull request Oct 6, 2024

sparrow: pin JDK 23 #346908

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK updates and removals #344544

JDK updates and removals #344544

emilazy commented Sep 25, 2024 •

edited

Loading

emilazy commented Sep 25, 2024 •

edited

Loading

Infinidoge Sep 26, 2024

emilazy Sep 26, 2024

Infinidoge commented Sep 26, 2024

rollf commented Sep 26, 2024

thiagokokada commented Sep 26, 2024

rollf commented Sep 26, 2024

Tungsten842 commented Sep 26, 2024

emilazy commented Sep 26, 2024

thiagokokada commented Sep 26, 2024

emilazy commented Sep 26, 2024

emilazy commented Sep 26, 2024

emilazy commented Sep 26, 2024

thiagokokada left a comment

thiagokokada commented Sep 26, 2024

thiagokokada commented Sep 27, 2024

thiagokokada commented Sep 27, 2024

	openjdk22_headless = openjdk20; # Added 2024-09-24
	openjdk22_headless = openjdk22; # Added 2024-09-24

JDK updates and removals #344544

JDK updates and removals #344544

Conversation

emilazy commented Sep 25, 2024 • edited Loading

Description of changes

Things done

emilazy commented Sep 25, 2024 • edited Loading

Infinidoge Sep 26, 2024

Choose a reason for hiding this comment

emilazy Sep 26, 2024

Choose a reason for hiding this comment

Infinidoge commented Sep 26, 2024

rollf commented Sep 26, 2024

thiagokokada commented Sep 26, 2024

rollf commented Sep 26, 2024

Tungsten842 commented Sep 26, 2024

emilazy commented Sep 26, 2024

thiagokokada commented Sep 26, 2024

emilazy commented Sep 26, 2024

emilazy commented Sep 26, 2024

emilazy commented Sep 26, 2024

thiagokokada left a comment

Choose a reason for hiding this comment

thiagokokada commented Sep 26, 2024

thiagokokada commented Sep 27, 2024

thiagokokada commented Sep 27, 2024

emilazy commented Sep 25, 2024 •

edited

Loading

emilazy commented Sep 25, 2024 •

edited

Loading