Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable haskell-language-server for ghc9101 #345947

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jmatsushita
Copy link
Contributor

Also ties loose end from #337720 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@maralorn
Copy link
Member

maralorn commented Oct 2, 2024

Oh, damnit. I thought that did happen, but then it got drowned in the CI noise.

@maralorn maralorn merged commit cdeda1a into NixOS:haskell-updates Oct 2, 2024
8 of 9 checks passed
@maralorn
Copy link
Member

maralorn commented Oct 2, 2024

Thank you for finding that.

@jmatsushita
Copy link
Contributor Author

jmatsushita commented Nov 8, 2024

UPDATE: I think I figured it out in #354537

Hey @maralorn I was sort of expecting for this change to result in haskell.packages.ghc910.haskell-language-server to be build by hydra and available in the nixos cache, however I can see haskell.packages.ghc98.haskell-language-server but https://hydra.nixos.org/job/nixpkgs/staging-next/haskell.packages.ghc910.haskell-language-server.x86_64-linux shows:

This job is not a member of the latest evaluation of its jobset. This means it was removed or had an evaluation error.

I don't really understand how all of this work, so suppose I was mistaken, but maybe you can help me figure out how to achieve this? Thanks !

@jmatsushita jmatsushita deleted the patch-1 branch November 8, 2024 15:00
jmatsushita added a commit to jmatsushita/nixpkgs that referenced this pull request Nov 8, 2024
As per NixOS#345947 ghc9101 is suppported by haskell-language-server so this should add it to hydra and the cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants