Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/atticd: init module #347749

Merged
merged 1 commit into from
Oct 14, 2024
Merged

nixos/atticd: init module #347749

merged 1 commit into from
Oct 14, 2024

Conversation

adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Oct 10, 2024 •
edited
Loading

Copied from https://github.com/zhaofengli/attic/blob/1b29816235b7573fca7f964709fd201e1a187024/nixos/atticd.nix and modified

  • Uses option helpers
  • Drop direct configFile setting
  • Set defaults for required chunking config
  • Added tests for local and s3 backends
  • Further service hardening

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 10, 2024
@adamcstephens adamcstephens marked this pull request as draft October 10, 2024 15:02
@adamcstephens adamcstephens mentioned this pull request Oct 10, 2024
Open
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 10, 2024
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Oct 10, 2024
@adamcstephens adamcstephens marked this pull request as ready for review October 12, 2024 14:14
@adamcstephens
Copy link
Contributor Author

adamcstephens commented Oct 12, 2024 •
edited
Loading

This is now ready for any reviews. There is some further hardening that can be added upstream, and possibly the tests if it would be helpful to have these in the attic repo.

@adamcstephens
Copy link
Contributor Author

@ofborg build attic-client.passthru.tests

Shawn8901
Shawn8901 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@Shawn8901 Shawn8901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zhaofengli
zhaofengli approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@zhaofengli zhaofengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will replicate these changes in the Attic version as well 👍

@adamcstephens adamcstephens merged commit 86420f4 into NixOS:master Oct 14, 2024
28 of 29 checks passed
@adamcstephens adamcstephens deleted the attic/init-module branch October 14, 2024 13:33
@zhaofengli zhaofengli mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shawn8901 Shawn8901 Shawn8901 approved these changes

@zhaofengli zhaofengli zhaofengli approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamcstephens @zhaofengli @Shawn8901 @h7x4