Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ddclient: Fix ip command with usev4 and usev6 #348622

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

jmir1
Copy link
Contributor

@jmir1 jmir1 commented Oct 14, 2024

Fixes #336189

Fixes a bug where the ip command would not be present if the newer usev4 and usev6 directives were used with ifv4/ifv6 by checking for it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jmir1
Copy link
Contributor Author

jmir1 commented Oct 18, 2024

@bjornfor can you review this?

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But can you please change the commit prefix from "ddclient:" to "nixos/ddclient:"?

@jmir1 jmir1 changed the title ddclient: Fix ip command with usev4 and usev6 nixos/ddclient: Fix ip command with usev4 and usev6 Oct 18, 2024
@bjornfor bjornfor merged commit 858b5c6 into NixOS:master Oct 18, 2024
16 of 17 checks passed
@jmir1 jmir1 deleted the fix-ddclient-ip-discovery branch October 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[services.ddclient] IP discovery fails with usev4=ifv4
2 participants